From: David Gibson <david@gibson.dropbear.id.au>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Peter Maydell <peter.maydell@linaro.org>,
Dmitry Fleytman <dmitry@daynix.com>,
Jason Wang <jasowang@redhat.com>, Fam Zheng <famz@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Michael Walle <michael@walle.cc>,
Laurent Vivier <laurent@vivier.eu>,
Aurelien Jarno <aurelien@aurel32.net>,
Yongbok Kim <yongbok.kim@mips.com>,
Anthony Green <green@moxielogic.com>,
Chris Wulff <crwulff@gmail.com>, Marek Vasut <marex@denx.de>,
Stafford Horne <shorne@gmail.com>, Alexander Graf <agraf@suse.de>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Max Filippov <jcmvbkbc@gmail.com>,
"open list:ARM cores" <qemu-arm@nongnu.org>,
"open list:PowerPC" <qemu-ppc@nongnu.org>,
"open list:S390" <qemu-s390x@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH 3/3] qdev: use device_class_set_parent_realize/unrealize/reset()
Date: Mon, 15 Jan 2018 12:42:24 +1100 [thread overview]
Message-ID: <20180115014224.GA2027@umbus.fritz.box> (raw)
In-Reply-To: <20180114020412.26160-4-f4bug@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Sat, Jan 13, 2018 at 11:04:12PM -0300, Philippe Mathieu-Daudé wrote:
1;5002;0c> changes generated using the following Coccinelle patch:
>
> @@
> type DeviceParentClass;
> DeviceParentClass *pc;
> DeviceClass *dc;
> identifier parent_fn;
> identifier child_fn;
> @@
> (
> +device_class_set_parent_realize(dc, child_fn, &pc->parent_fn);
> -pc->parent_fn = dc->realize;
> ...
> -dc->realize = child_fn;
> |
> +device_class_set_parent_unrealize(dc, child_fn, &pc->parent_fn);
> -pc->parent_fn = dc->unrealize;
> ...
> -dc->unrealize = child_fn;
> |
> +device_class_set_parent_reset(dc, child_fn, &pc->parent_fn);
> -pc->parent_fn = dc->reset;
> ...
> -dc->reset = child_fn;
> )
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
PPC parts
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-15 1:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 2:04 [Qemu-devel] [RFC PATCH 0/3] add helpers to be more explicit when using QOM abstract parent hooks Philippe Mathieu-Daudé
2018-01-14 2:04 ` [Qemu-devel] [RFC PATCH 1/3] qdev: rename typedef qdev_resetfn() -> DeviceReset() Philippe Mathieu-Daudé
2018-01-15 9:45 ` Laurent Vivier
2018-01-14 2:04 ` [Qemu-devel] [RFC PATCH 2/3] qdev: add helpers to be more explicit when using abstract QOM parent functions Philippe Mathieu-Daudé
2018-01-15 9:41 ` Laurent Vivier
2018-01-14 2:04 ` [Qemu-devel] [RFC PATCH 3/3] qdev: use device_class_set_parent_realize/unrealize/reset() Philippe Mathieu-Daudé
2018-01-15 1:42 ` David Gibson [this message]
2018-01-15 9:09 ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2018-01-15 9:35 ` [Qemu-devel] " Laurent Vivier
2018-01-15 9:48 ` Marcel Apfelbaum
2018-01-15 11:08 ` [Qemu-devel] [RFC PATCH 0/3] add helpers to be more explicit when using QOM abstract parent hooks Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115014224.GA2027@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=crwulff@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marcel@redhat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).