* [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled
@ 2018-01-15 2:35 Alexey Kardashevskiy
2018-01-15 6:48 ` Thomas Huth
2018-02-10 7:13 ` Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-15 2:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy
Even with --disable-git-update, ./configure tries updating the capstone
submodule instead of marking it "no"; this disables capstone submodule
if git update is disabled.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 89bd662..92c21b3 100755
--- a/configure
+++ b/configure
@@ -4502,7 +4502,7 @@ case "$capstone" in
"" | yes)
if $pkg_config capstone; then
capstone=system
- elif test -e "${source_path}/.git" ; then
+ elif test -e "${source_path}/.git" -a $git_update = 'yes' ; then
capstone=git
elif test -e "${source_path}/capstone/Makefile" ; then
capstone=internal
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled
2018-01-15 2:35 [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled Alexey Kardashevskiy
@ 2018-01-15 6:48 ` Thomas Huth
2018-01-29 6:44 ` Alexey Kardashevskiy
2018-02-10 7:13 ` Michael Tokarev
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2018-01-15 6:48 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel; +Cc: qemu-trivial
On 15.01.2018 03:35, Alexey Kardashevskiy wrote:
> Even with --disable-git-update, ./configure tries updating the capstone
> submodule instead of marking it "no"; this disables capstone submodule
> if git update is disabled.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 89bd662..92c21b3 100755
> --- a/configure
> +++ b/configure
> @@ -4502,7 +4502,7 @@ case "$capstone" in
> "" | yes)
> if $pkg_config capstone; then
> capstone=system
> - elif test -e "${source_path}/.git" ; then
> + elif test -e "${source_path}/.git" -a $git_update = 'yes' ; then
> capstone=git
> elif test -e "${source_path}/capstone/Makefile" ; then
> capstone=internal
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled
2018-01-15 6:48 ` Thomas Huth
@ 2018-01-29 6:44 ` Alexey Kardashevskiy
2018-01-29 6:59 ` Thomas Huth
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-29 6:44 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial
On 15/01/18 17:48, Thomas Huth wrote:
> On 15.01.2018 03:35, Alexey Kardashevskiy wrote:
>> Even with --disable-git-update, ./configure tries updating the capstone
>> submodule instead of marking it "no"; this disables capstone submodule
>> if git update is disabled.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 89bd662..92c21b3 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4502,7 +4502,7 @@ case "$capstone" in
>> "" | yes)
>> if $pkg_config capstone; then
>> capstone=system
>> - elif test -e "${source_path}/.git" ; then
>> + elif test -e "${source_path}/.git" -a $git_update = 'yes' ; then
>> capstone=git
>> elif test -e "${source_path}/capstone/Makefile" ; then
>> capstone=internal
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Thanks mate. What's next? :)
--
Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled
2018-01-29 6:44 ` Alexey Kardashevskiy
@ 2018-01-29 6:59 ` Thomas Huth
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2018-01-29 6:59 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, Laurent Vivier
On 29.01.2018 07:44, Alexey Kardashevskiy wrote:
> On 15/01/18 17:48, Thomas Huth wrote:
>> On 15.01.2018 03:35, Alexey Kardashevskiy wrote:
>>> Even with --disable-git-update, ./configure tries updating the capstone
>>> submodule instead of marking it "no"; this disables capstone submodule
>>> if git update is disabled.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 89bd662..92c21b3 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4502,7 +4502,7 @@ case "$capstone" in
>>> "" | yes)
>>> if $pkg_config capstone; then
>>> capstone=system
>>> - elif test -e "${source_path}/.git" ; then
>>> + elif test -e "${source_path}/.git" -a $git_update = 'yes' ; then
>>> capstone=git
>>> elif test -e "${source_path}/capstone/Makefile" ; then
>>> capstone=internal
>>>
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Thanks mate. What's next? :)
Put Paolo on CC in the hope that he can take it through the misc tree?
Or wait for the next trivial PULL request...
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled
2018-01-15 2:35 [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled Alexey Kardashevskiy
2018-01-15 6:48 ` Thomas Huth
@ 2018-02-10 7:13 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2018-02-10 7:13 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel; +Cc: QEMU Trivial
15.01.2018 05:35, Alexey Kardashevskiy wrote:
> Even with --disable-git-update, ./configure tries updating the capstone
> submodule instead of marking it "no"; this disables capstone submodule
> if git update is disabled.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-10 7:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 2:35 [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled Alexey Kardashevskiy
2018-01-15 6:48 ` Thomas Huth
2018-01-29 6:44 ` Alexey Kardashevskiy
2018-01-29 6:59 ` Thomas Huth
2018-02-10 7:13 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).