qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: [Qemu-devel] [PULL 14/27] migration: finalize current_migration object
Date: Mon, 15 Jan 2018 12:52:56 +0100	[thread overview]
Message-ID: <20180115115309.23982-15-quintela@redhat.com> (raw)
In-Reply-To: <20180115115309.23982-1-quintela@redhat.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

current_migration has .instance_finalize callback, but it is not
called, because nobody unrefs current_migration. Fix that.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 include/migration/misc.h | 1 +
 migration/migration.c    | 5 +++++
 vl.c                     | 1 +
 3 files changed, 7 insertions(+)

diff --git a/include/migration/misc.h b/include/migration/misc.h
index c079b7771b..77fd4f587c 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -44,6 +44,7 @@ void dump_vmstate_json_to_file(FILE *out_fp);
 
 /* migration/migration.c */
 void migration_object_init(void);
+void migration_object_finalize(void);
 void qemu_start_incoming_migration(const char *uri, Error **errp);
 bool migration_is_idle(void);
 void add_migration_state_change_notifier(Notifier *notify);
diff --git a/migration/migration.c b/migration/migration.c
index 17cc219da2..7a77b193c1 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -132,6 +132,11 @@ void migration_object_init(void)
     }
 }
 
+void migration_object_finalize(void)
+{
+    object_unref(OBJECT(current_migration));
+}
+
 /* For outgoing */
 MigrationState *migrate_get_current(void)
 {
diff --git a/vl.c b/vl.c
index 444b7507da..f1c52fe9fe 100644
--- a/vl.c
+++ b/vl.c
@@ -4792,6 +4792,7 @@ int main(int argc, char **argv, char **envp)
     monitor_cleanup();
     qemu_chr_cleanup();
     user_creatable_cleanup();
+    migration_object_finalize();
     /* TODO: unref root container, check all devices are ok */
 
     return 0;
-- 
2.14.3

  parent reply	other threads:[~2018-01-15 11:53 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 11:52 [Qemu-devel] [PULL 00/27] Migration pull Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 01/27] migration: Use proper types in json Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 02/27] migration: print features as on off Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 03/27] migration: free addr in the same function that we created it Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 04/27] docs: Convert migration.txt to rst Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 05/27] migration: free result string Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 06/27] migration: fix analyze-migration.py script with radix table Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 07/27] migration: introduce postcopy-blocktime capability Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 08/27] migration: add postcopy blocktime ctx into MigrationIncomingState Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 09/27] migration: calculate vCPU blocktime on dst side Juan Quintela
2018-01-15 20:19   ` Max Reitz
2018-01-16 13:19     ` Juan Quintela
2018-01-16 17:43     ` Dr. David Alan Gilbert
2018-01-16 19:22       ` Alexey Perevalov
2018-01-15 11:52 ` [Qemu-devel] [PULL 10/27] migration: postcopy_blocktime documentation Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 11/27] migration: add blocktime calculation into migration-test Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 12/27] migration: add postcopy total blocktime into query-migrate Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 13/27] migration: Guard ram_bytes_remaining against early call Juan Quintela
2018-01-15 11:52 ` Juan Quintela [this message]
2018-01-15 11:52 ` [Qemu-devel] [PULL 15/27] migration: assert colo instead of check Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 16/27] migration: qemu_savevm_state_cleanup() in cleanup Juan Quintela
2018-01-15 11:52 ` [Qemu-devel] [PULL 17/27] migration: remove "enable_colo" var Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 18/27] migration: split use of MigrationState.total_time Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 19/27] migration: move vm_old_running into global state Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 20/27] migration: introduce downtime_start Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 21/27] migration: introduce migrate_calculate_complete Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 22/27] migration: use switch at the end of migration Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 23/27] migration: cleanup stats update into function Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 24/27] migration: major cleanup for migrate iterations Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 25/27] migration: put the finish part into a new function Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 26/27] migration: remove some block_cleanup_parameters() Juan Quintela
2018-01-15 11:53 ` [Qemu-devel] [PULL 27/27] migration: remove notify in fd_error Juan Quintela
2018-01-15 16:14 ` [Qemu-devel] [PULL 00/27] Migration pull Peter Maydell
2018-01-19 16:27   ` Philippe Mathieu-Daudé
2018-01-19 16:34     ` Peter Maydell
2018-01-19 17:00       ` Philippe Mathieu-Daudé
2018-01-19 16:43     ` Alexey Perevalov
2018-01-19 17:01       ` Peter Maydell
2018-01-20 23:36         ` Juan Quintela
2018-01-21  3:19           ` Philippe Mathieu-Daudé
2018-01-22 10:03           ` Peter Maydell
2018-01-22 16:25             ` Alexey Perevalov
2018-01-22 16:26               ` Peter Maydell
2018-01-22 18:25                 ` Alexey Perevalov
2018-01-22 19:52                   ` Dr. David Alan Gilbert
2018-01-22 18:38           ` Alex Bennée
2018-01-22 12:22 ` Peter Maydell
2018-01-22 12:38   ` Dr. David Alan Gilbert
2018-01-22 13:38     ` Peter Maydell
2018-01-23 10:09       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115115309.23982-15-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).