From: Kevin Wolf <kwolf@redhat.com>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, agraf@suse.de,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct
Date: Mon, 15 Jan 2018 15:49:44 +0100 [thread overview]
Message-ID: <20180115144944.GG32271@localhost.localdomain> (raw)
In-Reply-To: <20171012235439.19457-2-anatol.pomozov@gmail.com>
Am 13.10.2017 um 01:54 hat Anatol Pomozov geschrieben:
> Using C structs makes the code more readable and prevents type conversion
> errors.
>
> Borrow multiboot1 header from GRUB project.
>
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
> ---
> hw/i386/multiboot.c | 124 +++++++++------------
> hw/i386/multiboot_header.h | 254 ++++++++++++++++++++++++++++++++++++++++++++
> tests/multiboot/mmap.c | 14 +--
> tests/multiboot/mmap.out | 10 ++
> tests/multiboot/modules.c | 12 ++-
> tests/multiboot/modules.out | 10 ++
> tests/multiboot/multiboot.h | 66 ------------
> 7 files changed, 339 insertions(+), 151 deletions(-)
> create mode 100644 hw/i386/multiboot_header.h
> delete mode 100644 tests/multiboot/multiboot.h
This is a good change in general. However, I'm not sure if we should
really replace the header used in the tests. After all, the tests also
test whether things are at the right place, and if there is an error in
the header file, we can only catch it if the tests keep using their own
definitions.
Kevin
next prev parent reply other threads:[~2018-01-15 14:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 23:54 [Qemu-devel] (no subject) Anatol Pomozov
2017-10-12 23:54 ` [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct Anatol Pomozov
2018-01-15 14:49 ` Kevin Wolf [this message]
2018-01-29 18:21 ` Anatol Pomozov
2018-01-29 20:02 ` Kevin Wolf
2018-02-09 21:48 ` Anatol Pomozov
2018-02-09 21:52 ` Anatol Pomozov
2018-02-12 13:33 ` Kevin Wolf
2018-02-12 13:37 ` Kevin Wolf
2017-10-12 23:54 ` [Qemu-devel] [PATCH 2/4] multiboot: load any machine type of ELF Anatol Pomozov
2017-10-13 19:25 ` Eduardo Habkost
2017-10-13 21:25 ` Anatol Pomozov
2017-10-13 23:21 ` Eduardo Habkost
2017-10-14 13:41 ` Peter Maydell
2017-10-16 8:27 ` Kevin Wolf
2017-10-16 18:38 ` Anatol Pomozov
2018-01-15 14:52 ` Kevin Wolf
2018-01-29 18:35 ` Anatol Pomozov
2017-10-12 23:54 ` [Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers Anatol Pomozov
2017-10-18 17:22 ` Anatol Pomozov
2017-10-19 9:36 ` Kevin Wolf
2017-10-31 18:38 ` Anatol Pomozov
2017-11-17 21:33 ` Anatol Pomozov
2017-11-20 16:45 ` Kevin Wolf
2018-01-15 15:41 ` Kevin Wolf
2018-01-29 19:16 ` Anatol Pomozov
2017-10-12 23:54 ` [Qemu-devel] [PATCH 4/4] multiboot: make tests work with clang Anatol Pomozov
2017-10-13 8:01 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2018-01-29 20:43 [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct Anatol Pomozov
2018-01-30 23:15 ` Jack Schwartz
2018-01-31 9:12 ` Kevin Wolf
2018-02-05 21:43 ` Anatol Pomozov
2018-02-06 20:35 ` Jack Schwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115144944.GG32271@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=agraf@suse.de \
--cc=anatol.pomozov@gmail.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).