From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebHUJ-0002ML-Lk for qemu-devel@nongnu.org; Mon, 15 Jan 2018 22:00:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebHUG-0001nS-DH for qemu-devel@nongnu.org; Mon, 15 Jan 2018 22:00:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54444) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ebHUF-0001mW-WD for qemu-devel@nongnu.org; Mon, 15 Jan 2018 22:00:32 -0500 Date: Tue, 16 Jan 2018 05:00:27 +0200 From: "Michael S. Tsirkin" Message-ID: <20180116045637-mutt-send-email-mst@kernel.org> References: <20180112145658.17121-1-maxime.coquelin@redhat.com> <20180112145658.17121-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180112145658.17121-2-maxime.coquelin@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] vhost-user: fix multiple queue specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Maxime Coquelin Cc: qemu-devel@nongnu.org, mlureau@redhat.com, zhengxiang9@huawei.com, lersek@redhat.com, pbonzini@redhat.com On Fri, Jan 12, 2018 at 03:56:55PM +0100, Maxime Coquelin wrote: > The number of queues supported by the slave is queried with > message VHOST_USER_GET_QUEUE_NUM, not with message > VHOST_USER_GET_PROTOCOL_FEATURES. > > Also, looking at master and slave implemntations, the payload > returned by the slave is the number of queue pairs supported > by the slave, not the number of queues. virtio doesn't have a concept of queue pairs. virtio net does have a concept of a tx/rx pair for purposes of steering. Would this be a slave bug then? I've applied the 1st chunk for now. > Signed-off-by: Maxime Coquelin > --- > docs/interop/vhost-user.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.txt > index d49444e037..8a14191a1e 100644 > --- a/docs/interop/vhost-user.txt > +++ b/docs/interop/vhost-user.txt > @@ -214,8 +214,8 @@ Multiple queue is treated as a protocol extension, hence the slave has to > implement protocol features first. The multiple queues feature is supported > only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set. > > -The max number of queues the slave supports can be queried with message > -VHOST_USER_GET_PROTOCOL_FEATURES. Master should stop when the number of > +The max number of queue pairs the slave supports can be queried with message > +VHOST_USER_GET_QUEUE_NUM. Master should stop when the number of > requested queues is bigger than that. > > As all queues share one connection, the master uses a unique index for each > @@ -537,7 +537,7 @@ Master message types > Master payload: N/A > Slave payload: u64 > > - Query how many queues the backend supports. This request should be > + Query how many queue pairs the backend supports. This request should be > sent only when VHOST_USER_PROTOCOL_F_MQ is set in queried protocol > features by VHOST_USER_GET_PROTOCOL_FEATURES. > > -- > 2.14.3