From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebQDP-0006Cn-PO for qemu-devel@nongnu.org; Tue, 16 Jan 2018 07:19:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebQDL-0005wX-0a for qemu-devel@nongnu.org; Tue, 16 Jan 2018 07:19:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45108) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ebQDK-0005pq-RJ for qemu-devel@nongnu.org; Tue, 16 Jan 2018 07:19:38 -0500 Date: Tue, 16 Jan 2018 20:19:31 +0800 From: Peter Xu Message-ID: <20180116121931.GC7031@xz-mi> References: <1516099892-34247-1-git-send-email-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1516099892-34247-1-git-send-email-wei.w.wang@intel.com> Subject: Re: [Qemu-devel] [PATCH v1] migration: use s->threshold_size inside migration_update_counters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Wang Cc: qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com On Tue, Jan 16, 2018 at 06:51:32PM +0800, Wei Wang wrote: > The threshold size is changed to be recorded in s->threshold_size by > commit b15df1ae5063c7c181f8f068f9eba7661b3b5e1. > > Signed-off-by: Wei Wang Could you help confirm the commit ID? Since what I see is b15df1ae50. Otherwise: Reviewed-by: Peter Xu And I'd prefer add: Fixes: b15df1ae50 ("migration: cleanup stats update into function") Thanks for the patch! -- Peter Xu