From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL v2 3/4] tcg/ppc: Support tlb offsets larger than 64k
Date: Tue, 16 Jan 2018 08:45:59 -0800 [thread overview]
Message-ID: <20180116164600.7480-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180116164600.7480-1-richard.henderson@linaro.org>
AArch64 with SVE has an offset of 80k to the 8th TLB.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/ppc/tcg-target.inc.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c
index 879885b68b..74f9b4aa34 100644
--- a/tcg/ppc/tcg-target.inc.c
+++ b/tcg/ppc/tcg-target.inc.c
@@ -1524,16 +1524,15 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGMemOp opc,
/* Compensate for very large offsets. */
if (add_off >= 0x8000) {
- /* Most target env are smaller than 32k; none are larger than 64k.
- Simplify the logic here merely to offset by 0x7ff0, giving us a
- range just shy of 64k. Check this assumption. */
- QEMU_BUILD_BUG_ON(offsetof(CPUArchState,
- tlb_table[NB_MMU_MODES - 1][1])
- > 0x7ff0 + 0x7fff);
- tcg_out32(s, ADDI | TAI(TCG_REG_TMP1, base, 0x7ff0));
+ int low = (int16_t)cmp_off;
+ int high = cmp_off - low;
+ assert((high & 0xffff) == 0);
+ assert(cmp_off - high == (int16_t)(cmp_off - high));
+ assert(add_off - high == (int16_t)(add_off - high));
+ tcg_out32(s, ADDIS | TAI(TCG_REG_TMP1, base, high >> 16));
base = TCG_REG_TMP1;
- cmp_off -= 0x7ff0;
- add_off -= 0x7ff0;
+ cmp_off -= high;
+ add_off -= high;
}
/* Extraction and shifting, part 2. */
--
2.14.3
next prev parent reply other threads:[~2018-01-16 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 16:45 [Qemu-devel] [PULL v2 0/4] tcg queued patches Richard Henderson
2018-01-16 16:45 ` [Qemu-devel] [PULL v2 1/4] tcg/arm: Fix double-word comparisons Richard Henderson
2018-01-16 16:45 ` [Qemu-devel] [PULL v2 2/4] tcg/arm: Support tlb offsets larger than 64k Richard Henderson
2018-01-16 16:45 ` Richard Henderson [this message]
2018-01-16 16:46 ` [Qemu-devel] [PULL v2 4/4] tcg/ppc: Allow a 32-bit offset to the constant pool Richard Henderson
2018-01-16 18:58 ` [Qemu-devel] [PULL v2 0/4] tcg queued patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116164600.7480-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).