From: Peter Xu <peterx@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1] migration: use s->threshold_size inside migration_update_counters
Date: Wed, 17 Jan 2018 12:05:11 +0800 [thread overview]
Message-ID: <20180117040511.GB11804@xz-mi> (raw)
In-Reply-To: <5A5EA1A3.2030801@intel.com>
On Wed, Jan 17, 2018 at 09:06:43AM +0800, Wei Wang wrote:
> On 01/16/2018 08:19 PM, Peter Xu wrote:
> > On Tue, Jan 16, 2018 at 06:51:32PM +0800, Wei Wang wrote:
> > > The threshold size is changed to be recorded in s->threshold_size by
> > > commit b15df1ae5063c7c181f8f068f9eba7661b3b5e1.
> > >
> > > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > Could you help confirm the commit ID? Since what I see is
> > b15df1ae50. Otherwise:
> >
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> >
> > And I'd prefer add:
> >
> > Fixes: b15df1ae50 ("migration: cleanup stats update into function")
> >
> > Thanks for the patch!
> >
>
> Sure. b15df1ae50 is shortcut and works too. Agree with your change.
Ouch. I wasn't taking about shortcut or not... I must have pasted a
wrong commit ID of yours. Please forget that. :)
--
Peter Xu
prev parent reply other threads:[~2018-01-17 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 10:51 [Qemu-devel] [PATCH v1] migration: use s->threshold_size inside migration_update_counters Wei Wang
2018-01-16 12:19 ` Peter Xu
2018-01-17 1:06 ` Wei Wang
2018-01-17 4:05 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117040511.GB11804@xz-mi \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).