From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: mreitz@redhat.com, jsnow@redhat.com, qemu-block@nongnu.org,
Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] iotests: Disable some tests for compat=0.10
Date: Wed, 17 Jan 2018 10:54:20 -0600 [thread overview]
Message-ID: <20180117165420.15946-3-eblake@redhat.com> (raw)
In-Reply-To: <20180117165420.15946-1-eblake@redhat.com>
From: Max Reitz <mreitz@redhat.com>
Tests 080, 130, 137, and 176 simply do not work with compat=0.10 for the
reasons stated there.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20171123020832.8165-10-mreitz@redhat.com>
[eblake: fix 177 in a separate commit]
Signed-off-by: Eric Blake <eblake@redhat.com>
---
tests/qemu-iotests/080 | 5 +++--
tests/qemu-iotests/130 | 2 ++
tests/qemu-iotests/137 | 2 ++
tests/qemu-iotests/176 | 2 ++
4 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/080 b/tests/qemu-iotests/080
index 55044c700be..1c2bd85742a 100755
--- a/tests/qemu-iotests/080
+++ b/tests/qemu-iotests/080
@@ -41,8 +41,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt qcow2
_supported_proto file
_supported_os Linux
-# Internal snapshots are (currently) impossible with refcount_bits=1
-_unsupported_imgopts 'refcount_bits=1[^0-9]'
+# - Internal snapshots are (currently) impossible with refcount_bits=1
+# - This is generally a test for compat=1.1 images
+_unsupported_imgopts 'refcount_bits=1[^0-9]' 'compat=0.10'
header_size=104
diff --git a/tests/qemu-iotests/130 b/tests/qemu-iotests/130
index e7e43de6d60..2c4b94da1bf 100755
--- a/tests/qemu-iotests/130
+++ b/tests/qemu-iotests/130
@@ -45,6 +45,8 @@ _supported_fmt qcow2
_supported_proto generic
_unsupported_proto vxhs
_supported_os Linux
+# We are going to use lazy-refcounts
+_unsupported_imgopts 'compat=0.10'
qemu_comm_method="monitor"
diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137
index eb91e517d7d..5a01250005f 100755
--- a/tests/qemu-iotests/137
+++ b/tests/qemu-iotests/137
@@ -41,6 +41,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt qcow2
_supported_proto file
_supported_os Linux
+# We are going to use lazy-refcounts
+_unsupported_imgopts 'compat=0.10'
_make_test_img 64M
diff --git a/tests/qemu-iotests/176 b/tests/qemu-iotests/176
index b8dc17c5920..d38b3aeb919 100755
--- a/tests/qemu-iotests/176
+++ b/tests/qemu-iotests/176
@@ -48,6 +48,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt qcow2
_supported_proto file
_supported_os Linux
+# Persistent dirty bitmaps require compat=1.1
+_unsupported_imgopts 'compat=0.10'
function run_qemu()
{
--
2.14.3
next prev parent reply other threads:[~2018-01-17 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 16:54 [Qemu-devel] [PATCH 0/2] iotests compat=0.10 fixes Eric Blake
2018-01-17 16:54 ` [Qemu-devel] [PATCH 1/2] iotests: Split 177 into two parts for compat=0.10 Eric Blake
2018-01-17 16:54 ` Eric Blake [this message]
2018-01-17 19:46 ` [Qemu-devel] [PATCH 0/2] iotests compat=0.10 fixes Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117165420.15946-3-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).