From: "Daniel P. Berrange" <berrange@redhat.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/4] QIOChannelFile bug fixes
Date: Thu, 18 Jan 2018 13:47:16 +0000 [thread overview]
Message-ID: <20180118134716.GQ19695@redhat.com> (raw)
In-Reply-To: <047d4fd6-aa7c-4b56-f8d9-3624d2d8d9ec@citrix.com>
On Thu, Jan 18, 2018 at 01:40:30PM +0000, Ross Lagerwall wrote:
> On 11/01/2017 02:25 PM, Ross Lagerwall wrote:
> > Hi,
> >
> > Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an
> > improvement to implementation of QIOChannelFile.
> >
> > Regards,
> > Ross Lagerwall
> >
> > Ross Lagerwall (4):
> > migration: Don't leak IO channels
> > io: Fix QIOChannelFile when creating and opening read-write
> > io: Don't call close multiple times in QIOChannelFile
> > io: Add /dev/fdset/ support to QIOChannelFile
> >
> > include/io/channel-file.h | 2 +-
> > io/channel-file.c | 11 ++++-------
> > migration/savevm.c | 2 ++
> > tests/test-io-channel-file.c | 29 +++++++++++++++++++++++++----
> > 4 files changed, 32 insertions(+), 12 deletions(-)
> >
>
> Ping for reviews...
>
> v1:
> Got feedback from Daniel P. Berrange and Marc-André Lureau.
>
> v2:
> Patch 1: Unreviewed
> Patch 2: Unreviewed
> Patch 3: Reviewed by Marc-André Lureau
> Patch 4: Reviewed by Marc-André Lureau
>
> The patch series still applies cleanly on top of master.
Sorry my bad for forgetting this. I'll review it now.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-01-18 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 14:25 [Qemu-devel] [PATCH v2 0/4] QIOChannelFile bug fixes Ross Lagerwall
2017-11-01 14:25 ` [Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels Ross Lagerwall
2018-01-18 13:41 ` Ross Lagerwall
2018-01-18 13:44 ` Daniel P. Berrange
2018-02-06 11:17 ` Dr. David Alan Gilbert
2017-11-01 14:25 ` [Qemu-devel] [PATCH v2 2/4] io: Fix QIOChannelFile when creating and opening read-write Ross Lagerwall
2018-01-18 13:49 ` Daniel P. Berrange
2017-11-01 14:25 ` [Qemu-devel] [PATCH v2 3/4] io: Don't call close multiple times in QIOChannelFile Ross Lagerwall
2017-11-01 18:11 ` Marc-André Lureau
2018-01-18 13:50 ` Daniel P. Berrange
2017-11-01 14:25 ` [Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile Ross Lagerwall
2017-11-01 18:12 ` Marc-André Lureau
2018-01-18 13:50 ` Daniel P. Berrange
2018-01-18 13:40 ` [Qemu-devel] [PATCH v2 0/4] QIOChannelFile bug fixes Ross Lagerwall
2018-01-18 13:47 ` Daniel P. Berrange [this message]
2018-01-18 13:51 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118134716.GQ19695@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.lagerwall@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).