* [Qemu-devel] [PATCH] sm501: Add missing break to case
@ 2018-01-18 18:01 BALATON Zoltan
2018-01-19 4:16 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: BALATON Zoltan @ 2018-01-18 18:01 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: Peter Maydell, David Gibson, Greg Kurz, Michael Roth
Noticed by Coverity, forgotten in 5690d9ece
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/display/sm501.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 4f7dc59b2..134cbed 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
break;
case SM501_COMMAND_LIST_STATUS:
ret = 0x00180002; /* FIFOs are empty, everything idle */
+ break;
case SM501_IRQ_MASK:
ret = s->irq_mask;
break;
--
2.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] sm501: Add missing break to case
2018-01-18 18:01 [Qemu-devel] [PATCH] sm501: Add missing break to case BALATON Zoltan
@ 2018-01-19 4:16 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2018-01-19 4:16 UTC (permalink / raw)
To: BALATON Zoltan
Cc: qemu-devel, qemu-ppc, Peter Maydell, Greg Kurz, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On Thu, Jan 18, 2018 at 07:01:19PM +0100, BALATON Zoltan wrote:
> Noticed by Coverity, forgotten in 5690d9ece
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Applied to ppc-for-2.12, thanks.
> ---
> hw/display/sm501.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 4f7dc59b2..134cbed 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
> break;
> case SM501_COMMAND_LIST_STATUS:
> ret = 0x00180002; /* FIFOs are empty, everything idle */
> + break;
> case SM501_IRQ_MASK:
> ret = s->irq_mask;
> break;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-18 18:01 [Qemu-devel] [PATCH] sm501: Add missing break to case BALATON Zoltan
2018-01-19 4:16 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).