From: David Gibson <david@gibson.dropbear.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, Andrea Bolognani <abologna@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties
Date: Fri, 19 Jan 2018 16:19:26 +1100 [thread overview]
Message-ID: <20180119051926.GI30352@umbus.fritz.box> (raw)
In-Reply-To: <20180119050906.18930-1-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Fri, Jan 19, 2018 at 04:09:06PM +1100, Alexey Kardashevskiy wrote:
> There is already 'device-list-properties' which does most of the job,
> however it does not handle everything returned by qom-list-types such
> as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE.
>
> This adds a new qom-list-properties command which prints properties
> of a specific class and its instance. It is pretty much a simplified copy
> of the device-list-properties handler.
>
> Since it creates an object instance, device properties should appear
> in the output as they are copied to QOM properties at the instance_init
> hook.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
I think the existing qom-list interface does this already.
This won't solve the libvirt problem we were discussing, because it
needs an existing instance of the object. libvirt wants to know the
machine properties *without* instantiating an instance.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-19 5:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 5:09 [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-01-19 5:19 ` David Gibson [this message]
2018-01-19 6:15 ` Alexey Kardashevskiy
2018-01-19 6:22 ` Alexey Kardashevskiy
2018-01-19 14:34 ` Andrea Bolognani
2018-01-23 10:08 ` Andrea Bolognani
2018-01-23 11:20 ` David Gibson
2018-01-23 12:03 ` Andrea Bolognani
2018-01-23 12:49 ` David Gibson
2018-01-23 13:33 ` Andrea Bolognani
2018-01-31 9:03 ` Alexey Kardashevskiy
2018-01-31 17:22 ` Markus Armbruster
2018-01-31 17:22 ` Markus Armbruster
2018-02-02 2:02 ` Alexey Kardashevskiy
2018-02-02 7:37 ` Markus Armbruster
2018-02-05 3:30 ` Alexey Kardashevskiy
2018-02-07 12:18 ` Andrea Bolognani
2018-02-21 3:36 ` Alexey Kardashevskiy
2018-02-21 10:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119051926.GI30352@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=abologna@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).