From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
boost.lists@gmail.com, quintela@redhat.com, jasowang@redhat.com,
mst@redhat.com, zuban32s@gmail.com,
maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru,
kraxel@redhat.com, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: [Qemu-devel] [RFC PATCH v4 09/23] replay: make safe vmstop at record/replay
Date: Fri, 19 Jan 2018 11:43:44 +0300 [thread overview]
Message-ID: <20180119084344.7100.74280.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20180119084235.7100.98318.stgit@pasha-VirtualBox>
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
This patch disables bdrv flush/drain in record/replay mode.
When block request is in the replay queue it cannot be processed
with drain/flush until it is found in the log.
Therefore vm should just stop leaving unfinished operations
in the queue.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
cpus.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/cpus.c b/cpus.c
index 2cb0af9..7b6ce74 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1004,9 +1004,10 @@ static int do_vm_stop(RunState state)
qapi_event_send_stop(&error_abort);
}
- bdrv_drain_all();
- replay_disable_events();
- ret = bdrv_flush_all();
+ if (!replay_events_enabled()) {
+ bdrv_drain_all();
+ ret = bdrv_flush_all();
+ }
return ret;
}
next prev parent reply other threads:[~2018-01-19 8:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 8:42 [Qemu-devel] [RFC PATCH v4 00/23] replay additions Pavel Dovgalyuk
2018-01-19 8:42 ` [Qemu-devel] [RFC PATCH v4 01/23] This patch adds a condition before overwriting exception_index fields Pavel Dovgalyuk
2018-01-19 8:47 ` Paolo Bonzini
2018-01-19 8:42 ` [Qemu-devel] [RFC PATCH v4 02/23] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-01-19 8:42 ` [Qemu-devel] [RFC PATCH v4 03/23] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 04/23] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 05/23] replay: fix processing async events Pavel Dovgalyuk
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 06/23] replay: fixed replay_enable_events Pavel Dovgalyuk
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 07/23] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 08/23] replay: added replay log format description Pavel Dovgalyuk
2018-01-19 8:43 ` Pavel Dovgalyuk [this message]
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 10/23] replay: save prior value of the host clock Pavel Dovgalyuk
2018-01-19 8:43 ` [Qemu-devel] [RFC PATCH v4 11/23] target/arm/arm-powertctl: drop BQL assertions Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 12/23] cpus: push BQL lock to qemu_*_wait_io_event Pavel Dovgalyuk
2018-01-19 8:55 ` Paolo Bonzini
2018-01-19 11:52 ` Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 13/23] cpus: only take BQL for sleeping threads Pavel Dovgalyuk
2018-01-19 8:59 ` Paolo Bonzini
2018-01-19 12:05 ` Pavel Dovgalyuk
2018-01-19 12:19 ` Paolo Bonzini
2018-01-19 12:25 ` Pavel Dovgalyuk
2018-01-19 12:26 ` Paolo Bonzini
2018-01-19 12:36 ` Pavel Dovgalyuk
2018-01-19 13:20 ` Pavel Dovgalyuk
2018-01-19 13:33 ` Paolo Bonzini
2018-01-22 6:47 ` Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 14/23] replay/replay.c: bump REPLAY_VERSION again Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 15/23] replay/replay-internal.c: track holding of replay_lock Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 16/23] replay: make locking visible outside replay code Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 17/23] replay: push replay_mutex_lock up the call tree Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 18/23] replay: don't destroy mutex at exit Pavel Dovgalyuk
2018-01-19 8:44 ` [Qemu-devel] [RFC PATCH v4 19/23] replay: check return values of fwrite Pavel Dovgalyuk
2018-01-19 8:45 ` [Qemu-devel] [RFC PATCH v4 20/23] replay: avoid recursive call of checkpoints Pavel Dovgalyuk
2018-01-19 8:45 ` [Qemu-devel] [RFC PATCH v4 21/23] scripts/replay-dump.py: replay log dumper Pavel Dovgalyuk
2018-01-19 8:45 ` [Qemu-devel] [RFC PATCH v4 22/23] replay: don't process async events when warping the clock Pavel Dovgalyuk
2018-01-19 8:45 ` [Qemu-devel] [RFC PATCH v4 23/23] replay: save vmstate of the asynchronous events Pavel Dovgalyuk
2018-01-19 9:25 ` [Qemu-devel] [RFC PATCH v4 00/23] replay additions no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119084344.7100.74280.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=boost.lists@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).