From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: groug@kaod.org, surajjs@au1.ibm.com, lvivier@redhat.com,
agraf@suse.de, qemu-ppc@nognu.org, qemu-devel@nongnu.org,
BALATON Zoltan <balaton@eik.bme.hu>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 10/13] sm501: Add missing break to case
Date: Fri, 19 Jan 2018 20:40:12 +1100 [thread overview]
Message-ID: <20180119094015.28266-11-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180119094015.28266-1-david@gibson.dropbear.id.au>
From: BALATON Zoltan <balaton@eik.bme.hu>
Noticed by Coverity, forgotten in 5690d9ece
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/display/sm501.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 4f7dc59b25..134cbed607 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
break;
case SM501_COMMAND_LIST_STATUS:
ret = 0x00180002; /* FIFOs are empty, everything idle */
+ break;
case SM501_IRQ_MASK:
ret = s->irq_mask;
break;
--
2.14.3
next prev parent reply other threads:[~2018-01-19 9:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 9:40 [Qemu-devel] [PULL 00/13] ppc-for-2.12 queue 20180119 David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 01/13] default-configs/ppc64-softmmu: Include 32-bit configs instead of copying them David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 02/13] default-configs/ppc-softmmu: Restructure the switches according to the machines David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 03/13] hw/ppc/Makefile: Add a way to disable the PPC4xx boards David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 04/13] ppc: Deprecate qemu-system-ppcemb David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 05/13] target/ppc: fix doorbell and hypervisor doorbell definitions David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 06/13] target/ppc: msgsnd and msgclr instructions need hypervisor privilege David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 07/13] spapr: drop duplicate variable in spapr_core_plug() David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 08/13] spapr: fix device tree properties when using compatibility mode David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 09/13] target-ppc: optimize cmp translation David Gibson
2018-01-19 9:40 ` David Gibson [this message]
2018-01-19 9:40 ` [Qemu-devel] [PULL 11/13] sii3112: Add explicit type casts to avoid unintended sign extension David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 12/13] target/ppc: add support for hypervisor doorbells on book3s CPUs David Gibson
2018-01-19 9:40 ` [Qemu-devel] [PULL 13/13] target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate David Gibson
2018-01-19 14:11 ` [Qemu-devel] [PULL 00/13] ppc-for-2.12 queue 20180119 Peter Maydell
2018-01-19 14:58 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119094015.28266-11-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=balaton@eik.bme.hu \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nognu.org \
--cc=surajjs@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).