* [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free
@ 2018-01-19 11:44 Laurent Vivier
2018-01-19 12:16 ` Thomas Huth
2018-01-22 3:50 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2018-01-19 11:44 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Richard Henderson, Laurent Vivier
t64 is also unconditionally freed after the switch () { ... }
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target/m68k/translate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index f0e86a73d4..ea18df940a 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -969,7 +969,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
case OS_DOUBLE:
tcg_gen_qemu_ld64(t64, addr, index);
gen_helper_extf64(cpu_env, fp, t64);
- tcg_temp_free_i64(t64);
break;
case OS_EXTENDED:
if (m68k_feature(s->env, M68K_FEATURE_CF_FPU)) {
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free
2018-01-19 11:44 [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free Laurent Vivier
@ 2018-01-19 12:16 ` Thomas Huth
2018-01-22 3:50 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2018-01-19 12:16 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial, Richard Henderson
On 19.01.2018 12:44, Laurent Vivier wrote:
> t64 is also unconditionally freed after the switch () { ... }
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/translate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index f0e86a73d4..ea18df940a 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -969,7 +969,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
> case OS_DOUBLE:
> tcg_gen_qemu_ld64(t64, addr, index);
> gen_helper_extf64(cpu_env, fp, t64);
> - tcg_temp_free_i64(t64);
> break;
> case OS_EXTENDED:
> if (m68k_feature(s->env, M68K_FEATURE_CF_FPU)) {
>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free
2018-01-19 11:44 [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free Laurent Vivier
2018-01-19 12:16 ` Thomas Huth
@ 2018-01-22 3:50 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2018-01-22 3:50 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial
On 01/19/2018 03:44 AM, Laurent Vivier wrote:
> t64 is also unconditionally freed after the switch () { ... }
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/translate.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 3:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 11:44 [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free Laurent Vivier
2018-01-19 12:16 ` Thomas Huth
2018-01-22 3:50 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).