From: Cornelia Huck <cohuck@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests
Date: Fri, 19 Jan 2018 12:54:16 +0100 [thread overview]
Message-ID: <20180119125416.25c1dd7c.cohuck@redhat.com> (raw)
In-Reply-To: <1516297904-18188-1-git-send-email-imbrenda@linux.vnet.ibm.com>
On Thu, 18 Jan 2018 18:51:44 +0100
Claudio Imbrenda <imbrenda@linux.vnet.ibm.com> wrote:
> Fix storage attribute migration so that it does not fail for guests
> with more than a few GB of RAM.
> With such guests, the index in the buffer would go out of bounds,
> usually by large amounts, thus receiving -EFAULT from the kernel.
> Migration itself would be successful, but storage attributes would then
> not be migrated completely.
>
> This patch fixes the out of bounds access, and thus migration of all
> storage attributes when the guest have large amounts of memory.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
> Fixes: 903fd80b03243476 ("s390x/migration: Storage attributes device")
> ---
> hw/s390x/s390-stattrib-kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.
next prev parent reply other threads:[~2018-01-19 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 17:51 [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests Claudio Imbrenda
2018-01-19 11:54 ` Cornelia Huck [this message]
2018-01-19 12:17 ` Christian Borntraeger
2018-01-19 12:26 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119125416.25c1dd7c.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).