qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Richard Henderson <rth@twiddle.net>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] s390x/tcg: fixup TEST PROTECTION
Date: Fri, 19 Jan 2018 12:56:00 +0100	[thread overview]
Message-ID: <20180119125600.6941ae46.cohuck@redhat.com> (raw)
In-Reply-To: <20180112125452.8569-1-david@redhat.com>

On Fri, 12 Jan 2018 13:54:52 +0100
David Hildenbrand <david@redhat.com> wrote:

> CC == 2 can only happen due to a protection exception, not if memory is
> not available (PGM_ADDRESSING). So all PGM_ADDRESSING exceptions have to
> be forwarded to the guest.
> 
> Since the initial definition of TEST PROTECTION, we now read globals
> (e.g. PSW mask), so we have to correctly mark the instruction
> (otherwise, e.g. booting fedora 27 fails).
> 
> Also, the architecture explicitly specifies which exceptions are
> forwarded to the guest, this makes the code a little nicer.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  target/s390x/cpu.h        |  2 ++
>  target/s390x/helper.h     |  2 +-
>  target/s390x/EM_helper.c | 41 +++++++++++++++++++----------------------
>  3 files changed, 22 insertions(+), 23 deletions(-)

Thanks, applied.

      parent reply	other threads:[~2018-01-19 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 12:54 [Qemu-devel] [PATCH] s390x/tcg: fixup TEST PROTECTION David Hildenbrand
2018-01-17 15:37 ` David Hildenbrand
2018-01-18 12:48   ` Cornelia Huck
2018-01-19 11:56 ` Cornelia Huck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119125600.6941ae46.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).