From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecVl8-0005ZK-FN for qemu-devel@nongnu.org; Fri, 19 Jan 2018 07:27:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecVl7-0007Ls-NE for qemu-devel@nongnu.org; Fri, 19 Jan 2018 07:27:02 -0500 Date: Fri, 19 Jan 2018 13:26:57 +0100 From: Cornelia Huck Message-ID: <20180119132657.7563cdce.cohuck@redhat.com> In-Reply-To: References: <1516297904-18188-1-git-send-email-imbrenda@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Claudio Imbrenda , qemu-devel@nongnu.org, qemu-s390x@nongnu.org On Fri, 19 Jan 2018 13:17:29 +0100 Christian Borntraeger wrote: > On 01/18/2018 06:51 PM, Claudio Imbrenda wrote: > > Fix storage attribute migration so that it does not fail for guests > > with more than a few GB of RAM. > > With such guests, the index in the buffer would go out of bounds, > > usually by large amounts, thus receiving -EFAULT from the kernel. > > Migration itself would be successful, but storage attributes would then > > not be migrated completely. > > > > This patch fixes the out of bounds access, and thus migration of all > > storage attributes when the guest have large amounts of memory. > > > > Signed-off-by: Claudio Imbrenda > > Fixes: 903fd80b03243476 ("s390x/migration: Storage attributes device") > > Cc: stable ? Probably doesn't hurt for an out-of-bounds error. > > Reviewed-by: Christian Borntraeger > > > --- > > hw/s390x/s390-stattrib-kvm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) Updated the queued patch, thanks.