* [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h>
@ 2018-01-19 8:15 Cédric Le Goater
2018-01-19 8:30 ` Thomas Huth
2018-01-21 9:44 ` David Gibson
0 siblings, 2 replies; 3+ messages in thread
From: Cédric Le Goater @ 2018-01-19 8:15 UTC (permalink / raw)
To: qemu-ppc, qemu-devel, David Gibson; +Cc: Thomas Huth, Cédric Le Goater
This redefinition generates warnings on some clang compilers and older
gcc4.4.
...include/hw/ppc/pnv_xscom.h:24:24: warning: redefinition of typedef 'PnvChip' is a C11
feature [-Wtypedef-redefinition]
typedef struct PnvChip PnvChip;
^
...include/hw/ppc/pnv.h:65:3: note: previous definition is here
} PnvChip;
^
1 warning generated.
CC ppc64-softmmu/hw/ppc/pnv_xscom.o
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
include/hw/ppc/pnv_xscom.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
index fb1bd5df095a..255b26a5aaf6 100644
--- a/include/hw/ppc/pnv_xscom.h
+++ b/include/hw/ppc/pnv_xscom.h
@@ -21,8 +21,6 @@
#include "qom/object.h"
-typedef struct PnvChip PnvChip;
-
typedef struct PnvXScomInterface {
Object parent;
} PnvXScomInterface;
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h>
2018-01-19 8:15 [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> Cédric Le Goater
@ 2018-01-19 8:30 ` Thomas Huth
2018-01-21 9:44 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2018-01-19 8:30 UTC (permalink / raw)
To: Cédric Le Goater, qemu-ppc, qemu-devel, David Gibson
On 19.01.2018 09:15, Cédric Le Goater wrote:
> This redefinition generates warnings on some clang compilers and older
> gcc4.4.
>
> ...include/hw/ppc/pnv_xscom.h:24:24: warning: redefinition of typedef 'PnvChip' is a C11
> feature [-Wtypedef-redefinition]
> typedef struct PnvChip PnvChip;
> ^
> ...include/hw/ppc/pnv.h:65:3: note: previous definition is here
> } PnvChip;
> ^
> 1 warning generated.
> CC ppc64-softmmu/hw/ppc/pnv_xscom.o
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/hw/ppc/pnv_xscom.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index fb1bd5df095a..255b26a5aaf6 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,8 +21,6 @@
>
> #include "qom/object.h"
>
> -typedef struct PnvChip PnvChip;
> -
> typedef struct PnvXScomInterface {
> Object parent;
> } PnvXScomInterface;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h>
2018-01-19 8:15 [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> Cédric Le Goater
2018-01-19 8:30 ` Thomas Huth
@ 2018-01-21 9:44 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2018-01-21 9:44 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-ppc, qemu-devel, Thomas Huth
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
On Fri, Jan 19, 2018 at 09:15:11AM +0100, Cédric Le Goater wrote:
> This redefinition generates warnings on some clang compilers and older
> gcc4.4.
>
> ...include/hw/ppc/pnv_xscom.h:24:24: warning: redefinition of typedef 'PnvChip' is a C11
> feature [-Wtypedef-redefinition]
> typedef struct PnvChip PnvChip;
> ^
> ...include/hw/ppc/pnv.h:65:3: note: previous definition is here
> } PnvChip;
> ^
> 1 warning generated.
> CC ppc64-softmmu/hw/ppc/pnv_xscom.o
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied, thanks.
> ---
> include/hw/ppc/pnv_xscom.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
> index fb1bd5df095a..255b26a5aaf6 100644
> --- a/include/hw/ppc/pnv_xscom.h
> +++ b/include/hw/ppc/pnv_xscom.h
> @@ -21,8 +21,6 @@
>
> #include "qom/object.h"
>
> -typedef struct PnvChip PnvChip;
> -
> typedef struct PnvXScomInterface {
> Object parent;
> } PnvXScomInterface;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-21 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 8:15 [Qemu-devel] [PATCH] ppc/pnv: fix PnvChip redefinition in <hw/ppc/pnv_xscom.h> Cédric Le Goater
2018-01-19 8:30 ` Thomas Huth
2018-01-21 9:44 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).