qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amador Pahim <apahim@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, crosa@redhat.com, ehabkost@redhat.com,
	Amador Pahim <apahim@redhat.com>
Subject: [Qemu-devel] [PATCH v12 6/6] qemu.py: don't launch again before shutdown()
Date: Mon, 22 Jan 2018 21:50:33 +0100	[thread overview]
Message-ID: <20180122205033.24893-7-apahim@redhat.com> (raw)
In-Reply-To: <20180122205033.24893-1-apahim@redhat.com>

If a VM is launched, files are created and a cleanup is required before
a new launch. This cleanup is executed by shutdown(), so shutdown() must
be called even if the VM is manually terminated (i.e. using kill).

This patch creates a control to make sure launch() will not be executed
again if shutdown() is not called after the previous launch().

Signed-off-by: Amador Pahim <apahim@redhat.com>
---
 scripts/qemu.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 42a3fa5251..6c80edfd04 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -91,6 +91,7 @@ class QEMUMachine(object):
         self._qemu_full_args = None
         self._test_dir = test_dir
         self._temp_dir = None
+        self._launched = False
 
         # just in case logging wasn't configured by the main script:
         logging.basicConfig()
@@ -211,10 +212,15 @@ class QEMUMachine(object):
         Launch the VM and make sure we cleanup and expose the
         command line/output in case of exception
         """
+
+        if self._launched:
+            raise QEMUMachineError('VM already launched')
+
         self._iolog = None
         self._qemu_full_args = None
         try:
             self._launch()
+            self._launched = True
         except:
             self.shutdown()
 
@@ -267,6 +273,8 @@ class QEMUMachine(object):
                 command = ''
             LOG.warn(msg, exitcode, command)
 
+        self._launched = False
+
     def qmp(self, cmd, conv_keys=True, **args):
         '''Invoke a QMP command and return the response dict'''
         qmp_args = dict()
-- 
2.14.3

  parent reply	other threads:[~2018-01-22 20:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 20:50 [Qemu-devel] [PATCH v12 0/6] scripts/qemu.py fixes and cleanups Amador Pahim
2018-01-22 20:50 ` [Qemu-devel] [PATCH v12 1/6] qemu.py: better control of created files Amador Pahim
2018-02-01 20:40   ` Eduardo Habkost
2018-01-22 20:50 ` [Qemu-devel] [PATCH v12 2/6] qemu.py: refactor launch() Amador Pahim
2018-01-22 20:57   ` Eric Blake
2018-01-22 20:50 ` [Qemu-devel] [PATCH v12 3/6] qemu.py: always cleanup on shutdown() Amador Pahim
2018-01-22 20:50 ` [Qemu-devel] [PATCH v12 4/6] qemu.py: use poll() instead of 'returncode' Amador Pahim
2018-01-22 20:50 ` [Qemu-devel] [PATCH v12 5/6] qemu.py: cleanup redundant calls in launch() Amador Pahim
2018-01-22 20:50 ` Amador Pahim [this message]
2018-02-01 20:53 ` [Qemu-devel] [PATCH v12 0/6] scripts/qemu.py fixes and cleanups Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122205033.24893-7-apahim@redhat.com \
    --to=apahim@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).