From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
Peter Maydell <peter.maydell@linaro.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Andrzej Zaborowski" <balrogg@gmail.com>
Subject: [Qemu-devel] [PATCH v3 00/12] SDCard: housekeeping, add tracing (part 4)
Date: Tue, 23 Jan 2018 00:21:23 -0300 [thread overview]
Message-ID: <20180123032135.28863-1-f4bug@amsat.org> (raw)
Since v2:
- split again in 2... this part is cleanup/tracing
- add more tracepoints
- move some code reusable by sdbus in sdmmc-internal.h
Since v1:
- rewrote mostly all patches to keep it simpler.
$ git backport-diff
001/12:[0007] [FC] 'sdcard: reorder SDState struct members'
002/12:[0002] [FC] 'sdcard: replace DPRINTF() by trace events'
003/12:[down] 'sdcard: add a trace event for command responses'
004/12:[down] 'sdcard: replace fprintf() by qemu_hexdump()'
005/12:[0035] [FC] 'sdcard: add more trace events'
006/12:[down] 'sdcard: do not trace CMD55 when expecting ACMD'
007/12:[down] 'sdcard: define SDMMC_CMD_MAX instead of using the magic '64''
008/12:[0083] [FC] 'sdcard: display command name when tracing CMD/ACMD'
009/12:[down] 'sdcard: display protocol used when tracing'
010/12:[----] [--] 'sdcard: rename sd_set_$REG() functions called once as sd_reset_$REG()'
011/12:[0002] [FC] 'sdcard: use G_BYTE from cutils'
012/12:[0008] [FC] 'sdcard: use the registerfields API to access the OCR register'
Based-on: 20180123030630.26613-15-f4bug@amsat.org
Philippe Mathieu-Daudé (12):
sdcard: reorder SDState struct members
sdcard: replace DPRINTF() by trace events
sdcard: add a trace event for command responses
sdcard: replace fprintf() by qemu_hexdump()
sdcard: add more trace events
sdcard: do not trace CMD55 when expecting ACMD
sdcard: define SDMMC_CMD_MAX instead of using the magic '64'
sdcard: display command name when tracing CMD/ACMD
sdcard: display protocol used when tracing
sdcard: rename sd_set_$REG() functions called once as sd_reset_$REG()
sdcard: use G_BYTE from cutils
sdcard: use the registerfields API to access the OCR register
include/hw/sd/sd.h | 1 -
hw/sd/sdmmc-internal.h | 20 +++++
hw/sd/sd.c | 212 ++++++++++++++++++++++++++++++++++---------------
hw/sd/sdmmc-common.c | 72 +++++++++++++++++
hw/sd/Makefile.objs | 2 +-
hw/sd/trace-events | 20 +++++
6 files changed, 259 insertions(+), 68 deletions(-)
create mode 100644 hw/sd/sdmmc-internal.h
create mode 100644 hw/sd/sdmmc-common.c
--
2.15.1
next reply other threads:[~2018-01-23 3:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 3:21 Philippe Mathieu-Daudé [this message]
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 01/12] sdcard: reorder SDState struct members Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 02/12] sdcard: replace DPRINTF() by trace events Philippe Mathieu-Daudé
2018-01-31 16:12 ` Alistair Francis
2018-02-15 18:54 ` Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 03/12] sdcard: add a trace event for command responses Philippe Mathieu-Daudé
2018-01-31 16:13 ` Alistair Francis
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexdump() Philippe Mathieu-Daudé
2018-01-23 22:55 ` Alistair Francis
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 05/12] sdcard: add more trace events Philippe Mathieu-Daudé
2018-01-24 0:35 ` Alistair Francis
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 06/12] sdcard: do not trace CMD55 when expecting ACMD Philippe Mathieu-Daudé
2018-01-23 22:56 ` Alistair Francis
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 07/12] sdcard: define SDMMC_CMD_MAX instead of using the magic '64' Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 08/12] sdcard: display command name when tracing CMD/ACMD Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 09/12] sdcard: display protocol used when tracing Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 10/12] sdcard: rename sd_set_$REG() functions called once as sd_reset_$REG() Philippe Mathieu-Daudé
2018-01-31 16:28 ` Alistair Francis
2018-02-07 22:22 ` Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 11/12] sdcard: use G_BYTE from cutils Philippe Mathieu-Daudé
2018-01-23 3:21 ` [Qemu-devel] [PATCH v3 12/12] sdcard: use the registerfields API to access the OCR register Philippe Mathieu-Daudé
2018-01-23 22:58 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123032135.28863-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@xilinx.com \
--cc=balrogg@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=i.mitsyanko@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).