qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Andrea Bolognani <abologna@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties
Date: Tue, 23 Jan 2018 23:49:23 +1100	[thread overview]
Message-ID: <20180123124922.GB14832@umbus> (raw)
In-Reply-To: <1516709019.31897.4.camel@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

On Tue, Jan 23, 2018 at 01:03:39PM +0100, Andrea Bolognani wrote:
> On Tue, 2018-01-23 at 22:20 +1100, David Gibson wrote:
> > > David, I know you're busy with linux.conf.au, but it would be
> > > really helpful if you could carve out five minutes to look over
> > > Alexey's proposal again, with my reply above in mind, and let us
> > > know whether it looks a reasonable design. Doesn't have to be a
> > > review, just a quick feedback on the high-level idea.
> > 
> > It looks ok, I think, but I don't think I'm really the right person to
> > ask.  I do wonder if creating a throwaway instance could cause
> > trouble, especially for something like machine that might well have
> > gotten away with having global side-effects in the past.  I think we
> > need to talk with someone who knows more about qom and qapi - Markus
> > seems the obvious choice.
> 
> Good point. CC'ing Markus to try and grab his attention :)

It's also occurred to me that making a spapr specific approach to this
might not be quite as horrible as I initially thought.  The
capabilities table is global (and immutable) so coding up a
"get-spapr-caps" qapi entry point which encodes the stuff there into
json giving the names and allowed values of each cap would be fairly
straightforward.

Accurately retreiving default values would be trickier, not sure if
that's important or not.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-01-23 12:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  5:09 [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-01-19  5:19 ` David Gibson
2018-01-19  6:15   ` Alexey Kardashevskiy
2018-01-19  6:22     ` Alexey Kardashevskiy
2018-01-19 14:34     ` Andrea Bolognani
2018-01-23 10:08       ` Andrea Bolognani
2018-01-23 11:20         ` David Gibson
2018-01-23 12:03           ` Andrea Bolognani
2018-01-23 12:49             ` David Gibson [this message]
2018-01-23 13:33               ` Andrea Bolognani
2018-01-31  9:03               ` Alexey Kardashevskiy
2018-01-31 17:22                 ` Markus Armbruster
2018-01-31 17:22 ` Markus Armbruster
2018-02-02  2:02   ` Alexey Kardashevskiy
2018-02-02  7:37     ` Markus Armbruster
2018-02-05  3:30       ` Alexey Kardashevskiy
2018-02-07 12:18         ` Andrea Bolognani
2018-02-21  3:36 ` Alexey Kardashevskiy
2018-02-21 10:01   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180123124922.GB14832@umbus \
    --to=david@gibson.dropbear.id.au \
    --cc=abologna@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).