From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <shajnocz@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
Juan Quintela <quintela@redhat.com>,
mdroth@linux.vnet.ibm.com, peterx@redhat.com,
Eric Blake <eblake@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
marcandre.lureau@redhat.com,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH v7 05/23] monitor: move skip_flush into monitor_data_init
Date: Wed, 24 Jan 2018 13:39:39 +0800 [thread overview]
Message-ID: <20180124053957.29145-6-peterx@redhat.com> (raw)
In-Reply-To: <20180124053957.29145-1-peterx@redhat.com>
It's part of the data init. Collect it.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
monitor.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index b9da5e20d1..3a28a6d935 100644
--- a/monitor.c
+++ b/monitor.c
@@ -567,13 +567,14 @@ static void monitor_qapi_event_init(void)
static void handle_hmp_command(Monitor *mon, const char *cmdline);
-static void monitor_data_init(Monitor *mon)
+static void monitor_data_init(Monitor *mon, bool skip_flush)
{
memset(mon, 0, sizeof(Monitor));
qemu_mutex_init(&mon->out_lock);
mon->outbuf = qstring_new();
/* Use *mon_cmds by default. */
mon->cmd_table = mon_cmds;
+ mon->skip_flush = skip_flush;
}
static void monitor_data_destroy(Monitor *mon)
@@ -594,8 +595,7 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,
char *output = NULL;
Monitor *old_mon, hmp;
- monitor_data_init(&hmp);
- hmp.skip_flush = true;
+ monitor_data_init(&hmp, true);
old_mon = cur_mon;
cur_mon = &hmp;
@@ -4088,7 +4088,7 @@ void monitor_init(Chardev *chr, int flags)
}
mon = g_malloc(sizeof(*mon));
- monitor_data_init(mon);
+ monitor_data_init(mon, false);
qemu_chr_fe_init(&mon->chr, chr, &error_abort);
mon->flags = flags;
--
2.14.3
next prev parent reply other threads:[~2018-01-24 5:40 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 5:39 [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 01/23] docs: update QMP documents for OOB commands Peter Xu
2018-02-09 14:10 ` Eric Blake
2018-02-11 5:34 ` Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 02/23] qobject: introduce qstring_get_try_str() Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 03/23] qobject: introduce qobject_get_try_str() Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 04/23] qobject: let object_property_get_str() use new API Peter Xu
2018-01-24 5:39 ` Peter Xu [this message]
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 06/23] monitor: move the cur_mon hack deeper for QMP Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 07/23] monitor: unify global init Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 08/23] monitor: let mon_list be tail queue Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing Peter Xu
2018-02-21 16:00 ` Stefan Hajnoczi
2018-02-22 10:01 ` Peter Xu
2018-02-22 15:41 ` Stefan Hajnoczi
2018-02-22 15:50 ` Daniel P. Berrangé
2018-02-23 2:56 ` Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability Peter Xu
2018-02-21 16:17 ` Stefan Hajnoczi
2018-02-22 10:42 ` Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 11/23] monitor: introduce monitor_qmp_respond() Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe Peter Xu
2018-02-21 16:44 ` Stefan Hajnoczi
2018-02-21 16:45 ` Stefan Hajnoczi
2018-02-21 16:45 ` Stefan Hajnoczi
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs Peter Xu
2018-02-21 16:50 ` Stefan Hajnoczi
2018-02-22 10:49 ` Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 14/23] monitor: separate QMP parser and dispatcher Peter Xu
2018-02-21 17:17 ` Stefan Hajnoczi
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 15/23] qmp: add new event "command-dropped" Peter Xu
2018-02-21 17:19 ` Stefan Hajnoczi
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 16/23] monitor: send event when command queue full Peter Xu
2018-02-21 17:23 ` Stefan Hajnoczi
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-oob" Peter Xu
2018-03-08 10:04 ` Igor Mammedov
2018-03-08 11:43 ` Peter Xu
2018-03-08 11:51 ` Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 18/23] qmp: support out-of-band (oob) execution Peter Xu
2018-02-21 17:34 ` Stefan Hajnoczi
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 19/23] qmp: isolate responses into io thread Peter Xu
2018-02-21 17:44 ` Stefan Hajnoczi
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 20/23] monitor: enable IO thread for (qmp & !mux) typed Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 21/23] qmp: add command "x-oob-test" Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 22/23] tests: qmp-test: verify command batching Peter Xu
2018-01-24 5:39 ` [Qemu-devel] [PATCH v7 23/23] tests: qmp-test: add oob test Peter Xu
2018-01-25 2:35 ` [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support Peter Xu
2018-01-25 10:01 ` Dr. David Alan Gilbert
2018-02-08 6:44 ` Peter Xu
2018-02-21 17:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124053957.29145-6-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shajnocz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).