From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeI7l-0005L9-Ji for qemu-devel@nongnu.org; Wed, 24 Jan 2018 05:17:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeI7k-0006H4-Iy for qemu-devel@nongnu.org; Wed, 24 Jan 2018 05:17:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43292) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eeI7k-0006Go-CZ for qemu-devel@nongnu.org; Wed, 24 Jan 2018 05:17:44 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A03C5780DE for ; Wed, 24 Jan 2018 10:17:43 +0000 (UTC) Date: Wed, 24 Jan 2018 10:17:37 +0000 From: "Daniel P. Berrange" Message-ID: <20180124101737.GB29857@redhat.com> Reply-To: "Daniel P. Berrange" References: <20180123164718.12714-1-berrange@redhat.com> <20180123164718.12714-3-berrange@redhat.com> <68283d62-6bab-987b-b820-830606992b3a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <68283d62-6bab-987b-b820-830606992b3a@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau On Tue, Jan 23, 2018 at 01:05:31PM -0600, Eric Blake wrote: > On 01/23/2018 10:47 AM, Daniel P. Berrange wrote: > > The make rules for building QEMU are mostly silent by default. They can > > be made verbose by setting the variable V=1. The default state does not > > however correspond to a V=0 setting - $(V) must be undefined / empty to > > get the default quiet build. > > Makefiles generated by automake support V=0; how hard would it be to > instead tweak things so that 'V=' and 'V=0' have the same effect? Well it would make the various conmditionals a bit more complex because we'd have to check three states instead of two. I'm not really convinced it is worth it because explicitly passing V=0 doesn't do anything useful given that we are unconditionally silent by default. It makes more sense with autoconf, because the default behaviour may vary based on configure setup and/or configure args, so you can't assume that omitting 'V=' gives you silent build like we do with QEMU. > > > > > Signed-off-by: Daniel P. Berrange > > --- > > Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index c263190b8d..554ba69ced 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -940,4 +940,5 @@ ifdef QEMU_GA_MSI_ENABLED > > endif > > @echo '' > > endif > > - @echo ' $(MAKE) V=0|1 [targets] 0 => quiet build (default), 1 => verbose build' > > + @echo ' $(MAKE) [targets] (quiet build, default)' > > + @echo ' $(MAKE) V=1 [targets] (verbose build)' > > > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|