From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Guido Günther" <agx@sigxcpu.org>
Subject: [Qemu-devel] [RFC PATCH 01/11] linux-user/strace: dump AF_NETLINK sockaddr content
Date: Wed, 24 Jan 2018 10:01:16 -0300 [thread overview]
Message-ID: <20180124130126.20871-2-f4bug@amsat.org> (raw)
In-Reply-To: <20180124130126.20871-1-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
please double check __pad and ntohl()
linux-user/syscall_defs.h | 7 +++++++
linux-user/strace.c | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
index bec3680b94..550e7d2939 100644
--- a/linux-user/syscall_defs.h
+++ b/linux-user/syscall_defs.h
@@ -151,6 +151,13 @@ struct target_sockaddr_un {
uint8_t sun_path[108];
};
+struct target_sockaddr_nl {
+ uint16_t nl_family; /* AF_NETLINK */
+ int16_t __pad;
+ uint32_t nl_pid;
+ uint32_t nl_groups;
+};
+
struct target_in_addr {
uint32_t s_addr; /* big endian */
};
diff --git a/linux-user/strace.c b/linux-user/strace.c
index bd897a3f20..7eb5e2ab48 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -8,6 +8,7 @@
#include <arpa/inet.h>
#include <netinet/tcp.h>
#include <linux/if_packet.h>
+#include <linux/netlink.h>
#include <sched.h>
#include "qemu.h"
@@ -397,6 +398,12 @@ print_sockaddr(abi_ulong addr, abi_long addrlen)
gemu_log("}");
break;
}
+ case AF_NETLINK: {
+ struct target_sockaddr_nl *nl = (struct target_sockaddr_nl *)sa;
+ gemu_log("{nl_family=AF_NETLINK,nl_pid=%u,nl_groups=%u}",
+ ntohl(nl->nl_pid), ntohl(nl->nl_groups));
+ break;
+ }
default:
gemu_log("{sa_family=%d, sa_data={", sa->sa_family);
for (i = 0; i < 13; i++) {
@@ -423,6 +430,9 @@ print_socket_domain(int domain)
case PF_INET:
gemu_log("PF_INET");
break;
+ case PF_NETLINK:
+ gemu_log("PF_NETLINK");
+ break;
case PF_PACKET:
gemu_log("PF_PACKET");
break;
@@ -472,6 +482,30 @@ print_socket_protocol(int domain, int type, int protocol)
return;
}
+ if (domain == AF_NETLINK) {
+ switch (protocol) {
+ case NETLINK_ROUTE:
+ gemu_log("NETLINK_ROUTE");
+ break;
+ case NETLINK_AUDIT:
+ gemu_log("NETLINK_AUDIT");
+ break;
+ case NETLINK_NETFILTER:
+ gemu_log("NETLINK_NETFILTER");
+ break;
+ case NETLINK_RDMA:
+ gemu_log("NETLINK_RDMA");
+ break;
+ case NETLINK_CRYPTO:
+ gemu_log("NETLINK_CRYPTO");
+ break;
+ default:
+ gemu_log("%d", protocol);
+ break;
+ }
+ return;
+ }
+
switch (protocol) {
case IPPROTO_IP:
gemu_log("IPPROTO_IP");
--
2.15.1
next prev parent reply other threads:[~2018-01-24 13:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 13:01 [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace Philippe Mathieu-Daudé
2018-01-24 13:01 ` Philippe Mathieu-Daudé [this message]
2018-02-15 15:17 ` [Qemu-devel] [RFC PATCH 01/11] linux-user/strace: dump AF_NETLINK sockaddr content Laurent Vivier
2018-02-15 15:28 ` Philippe Mathieu-Daudé
2018-02-15 16:54 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 02/11] linux-user/strace: improve sendto() output Philippe Mathieu-Daudé
2018-02-15 17:41 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 03/11] linux-user/strace: add print_sockaddr_ptr() to handle plain/pointer addrlen Philippe Mathieu-Daudé
2018-02-17 18:10 ` Laurent Vivier
2018-06-28 1:50 ` Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 04/11] linux-user/strace: improve recvfrom() output Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 05/11] linux-user/strace: improve getsockname() output Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 06/11] linux-user/strace: improve recvmsg() output Philippe Mathieu-Daudé
2018-02-17 17:26 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 07/11] linux-user/strace: improve bind() output Philippe Mathieu-Daudé
2018-02-17 17:24 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 08/11] linux-user/strace: improve gettimeofday() output Philippe Mathieu-Daudé
2018-02-17 17:21 ` Laurent Vivier
2018-06-28 1:43 ` Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 09/11] linux-user/strace: improve capget()/capset() output Philippe Mathieu-Daudé
2018-02-17 17:15 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 10/11] linux-user/syscall: verify recvfrom(addr) is user-writable Philippe Mathieu-Daudé
2018-02-15 17:27 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 11/11] linux-user/syscall: simplify recvfrom() Philippe Mathieu-Daudé
2018-02-15 17:20 ` Laurent Vivier
2018-01-24 18:50 ` [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace Guido Günther
2018-01-24 19:45 ` Laurent Vivier
2018-01-28 11:12 ` Guido Günther
2018-01-28 21:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124130126.20871-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=agx@sigxcpu.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).