From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Guido Günther" <agx@sigxcpu.org>
Subject: [Qemu-devel] [PATCH 03/11] linux-user/strace: add print_sockaddr_ptr() to handle plain/pointer addrlen
Date: Wed, 24 Jan 2018 10:01:18 -0300 [thread overview]
Message-ID: <20180124130126.20871-4-f4bug@amsat.org> (raw)
In-Reply-To: <20180124130126.20871-1-f4bug@amsat.org>
since this argument differs between sendto()/recvfrom()
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
linux-user/strace.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index e7272f4ede..9726d9b378 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -335,12 +335,15 @@ static void print_siginfo(const target_siginfo_t *tinfo)
}
static void
-print_sockaddr(abi_ulong addr, abi_long addrlen)
+print_sockaddr_ptr(abi_ulong addr, abi_long addrlen, bool addrlen_ptr)
{
struct target_sockaddr *sa;
int i;
int sa_family;
+ if (addrlen_ptr) {
+ get_user_ual(addrlen, addrlen);
+ }
sa = lock_user(VERIFY_READ, addr, addrlen, 1);
if (sa) {
sa_family = tswap16(sa->sa_family);
@@ -417,7 +420,17 @@ print_sockaddr(abi_ulong addr, abi_long addrlen)
} else {
print_raw_param("0x"TARGET_ABI_FMT_lx, addr, 0);
}
- gemu_log(", "TARGET_ABI_FMT_ld, addrlen);
+ if (addrlen_ptr) {
+ gemu_log(", ["TARGET_ABI_FMT_ld"]", addrlen);
+ } else {
+ gemu_log(", "TARGET_ABI_FMT_ld, addrlen);
+ }
+}
+
+static void
+print_sockaddr(abi_ulong addr, abi_long addrlen)
+{
+ print_sockaddr_ptr(addr, addrlen, false);
}
static void
--
2.15.1
next prev parent reply other threads:[~2018-01-24 13:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 13:01 [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [RFC PATCH 01/11] linux-user/strace: dump AF_NETLINK sockaddr content Philippe Mathieu-Daudé
2018-02-15 15:17 ` Laurent Vivier
2018-02-15 15:28 ` Philippe Mathieu-Daudé
2018-02-15 16:54 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 02/11] linux-user/strace: improve sendto() output Philippe Mathieu-Daudé
2018-02-15 17:41 ` Laurent Vivier
2018-01-24 13:01 ` Philippe Mathieu-Daudé [this message]
2018-02-17 18:10 ` [Qemu-devel] [PATCH 03/11] linux-user/strace: add print_sockaddr_ptr() to handle plain/pointer addrlen Laurent Vivier
2018-06-28 1:50 ` Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 04/11] linux-user/strace: improve recvfrom() output Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 05/11] linux-user/strace: improve getsockname() output Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 06/11] linux-user/strace: improve recvmsg() output Philippe Mathieu-Daudé
2018-02-17 17:26 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 07/11] linux-user/strace: improve bind() output Philippe Mathieu-Daudé
2018-02-17 17:24 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 08/11] linux-user/strace: improve gettimeofday() output Philippe Mathieu-Daudé
2018-02-17 17:21 ` Laurent Vivier
2018-06-28 1:43 ` Philippe Mathieu-Daudé
2018-01-24 13:01 ` [Qemu-devel] [PATCH 09/11] linux-user/strace: improve capget()/capset() output Philippe Mathieu-Daudé
2018-02-17 17:15 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 10/11] linux-user/syscall: verify recvfrom(addr) is user-writable Philippe Mathieu-Daudé
2018-02-15 17:27 ` Laurent Vivier
2018-01-24 13:01 ` [Qemu-devel] [PATCH 11/11] linux-user/syscall: simplify recvfrom() Philippe Mathieu-Daudé
2018-02-15 17:20 ` Laurent Vivier
2018-01-24 18:50 ` [Qemu-devel] [PATCH 00/11] linux-user: improve NETLINK strace Guido Günther
2018-01-24 19:45 ` Laurent Vivier
2018-01-28 11:12 ` Guido Günther
2018-01-28 21:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124130126.20871-4-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=agx@sigxcpu.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).