* [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of local variable
@ 2018-01-25 4:14 Alexey Kardashevskiy
2018-01-25 13:53 ` Auger Eric
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-25 4:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, Alex Williamson
There is already @hostwin in vfio_listener_region_add() so there is no
point in having the other one.
Fixes: 2e4109de "vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2)"
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/vfio/common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index b77be3a..3d652c8 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -435,7 +435,6 @@ static void vfio_listener_region_add(MemoryListener *listener,
end = int128_get64(int128_sub(llend, int128_one()));
if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU) {
- VFIOHostDMAWindow *hostwin;
hwaddr pgsize = 0;
/* For now intersections are not allowed, we may relax this later */
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of local variable
2018-01-25 4:14 [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of local variable Alexey Kardashevskiy
@ 2018-01-25 13:53 ` Auger Eric
0 siblings, 0 replies; 2+ messages in thread
From: Auger Eric @ 2018-01-25 13:53 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel; +Cc: Alex Williamson
Hi,On 25/01/18 05:14, Alexey Kardashevskiy wrote:
> There is already @hostwin in vfio_listener_region_add() so there is no
> point in having the other one.
>
> Fixes: 2e4109de "vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2)"
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> hw/vfio/common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index b77be3a..3d652c8 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -435,7 +435,6 @@ static void vfio_listener_region_add(MemoryListener *listener,
> end = int128_get64(int128_sub(llend, int128_one()));
>
> if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU) {
> - VFIOHostDMAWindow *hostwin;
> hwaddr pgsize = 0;
>
> /* For now intersections are not allowed, we may relax this later */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-25 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-25 4:14 [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of local variable Alexey Kardashevskiy
2018-01-25 13:53 ` Auger Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).