From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL v4 42/43] target/hppa: Fix 32-bit operand masks for 0E FCVT
Date: Sun, 28 Jan 2018 15:15:27 -0800 [thread overview]
Message-ID: <20180128231528.22719-43-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180128231528.22719-1-richard.henderson@linaro.org>
We masked the wrong bits, which prevented some of the
32-bit R registers. E.g. "fcnvxf,sgl,sgl fr22R,fr6R".
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hppa/translate.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index b9b097acc9..c62ee72615 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -4381,34 +4381,34 @@ static const DisasInsn table_float_0e[] = {
/* floating point class one */
/* float/float */
{ 0x38000a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_d_s },
- { 0x38002200, 0xfc1fffc0, FOP_DEW = gen_helper_fcnv_s_d },
+ { 0x38002200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_s_d },
/* int/float */
- { 0x38008200, 0xfc1ffe60, FOP_WEW = gen_helper_fcnv_w_s },
+ { 0x38008200, 0xfc1ffe20, FOP_WEW = gen_helper_fcnv_w_s },
{ 0x38008a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_dw_s },
{ 0x3800a200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_w_d },
{ 0x3800aa00, 0xfc1fffe0, FOP_DED = gen_helper_fcnv_dw_d },
/* float/int */
- { 0x38010200, 0xfc1ffe60, FOP_WEW = gen_helper_fcnv_s_w },
+ { 0x38010200, 0xfc1ffe20, FOP_WEW = gen_helper_fcnv_s_w },
{ 0x38010a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_d_w },
{ 0x38012200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_s_dw },
{ 0x38012a00, 0xfc1fffe0, FOP_DED = gen_helper_fcnv_d_dw },
/* float/int truncate */
- { 0x38018200, 0xfc1ffe60, FOP_WEW = gen_helper_fcnv_t_s_w },
+ { 0x38018200, 0xfc1ffe20, FOP_WEW = gen_helper_fcnv_t_s_w },
{ 0x38018a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_t_d_w },
{ 0x3801a200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_t_s_dw },
{ 0x3801aa00, 0xfc1fffe0, FOP_DED = gen_helper_fcnv_t_d_dw },
/* uint/float */
- { 0x38028200, 0xfc1ffe60, FOP_WEW = gen_helper_fcnv_uw_s },
+ { 0x38028200, 0xfc1ffe20, FOP_WEW = gen_helper_fcnv_uw_s },
{ 0x38028a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_udw_s },
{ 0x3802a200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_uw_d },
{ 0x3802aa00, 0xfc1fffe0, FOP_DED = gen_helper_fcnv_udw_d },
/* float/uint */
- { 0x38030200, 0xfc1ffe60, FOP_WEW = gen_helper_fcnv_s_uw },
+ { 0x38030200, 0xfc1ffe20, FOP_WEW = gen_helper_fcnv_s_uw },
{ 0x38030a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_d_uw },
{ 0x38032200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_s_udw },
{ 0x38032a00, 0xfc1fffe0, FOP_DED = gen_helper_fcnv_d_udw },
/* float/uint truncate */
- { 0x38038200, 0xfc1ffe60, FOP_WEW = gen_helper_fcnv_t_s_uw },
+ { 0x38038200, 0xfc1ffe20, FOP_WEW = gen_helper_fcnv_t_s_uw },
{ 0x38038a00, 0xfc1fffa0, FOP_WED = gen_helper_fcnv_t_d_uw },
{ 0x3803a200, 0xfc1fff60, FOP_DEW = gen_helper_fcnv_t_s_udw },
{ 0x3803aa00, 0xfc1fffe0, FOP_DED = gen_helper_fcnv_t_d_udw },
--
2.14.3
next prev parent reply other threads:[~2018-01-28 23:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 23:14 [Qemu-devel] [PULL v4 00/43] hppa-softmmu Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 01/43] target/hppa: Skeleton support for hppa-softmmu Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 02/43] target/hppa: Define the rest of the PSW Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 03/43] target/hppa: Disable gateway page emulation for system mode Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 04/43] target/hppa: Define hardware exception types Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 05/43] target/hppa: Split address size from register size Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 06/43] target/hppa: Implement mmu_idx from IA privilege level Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 07/43] target/hppa: Implement the system mask instructions Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 08/43] target/hppa: Add space registers Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 09/43] target/hppa: Add control registers Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 10/43] target/hppa: Adjust insn mask for mfctl, w Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 11/43] target/hppa: Implement rfi Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 12/43] target/hppa: Fill in hppa_cpu_do_interrupt/hppa_cpu_exec_interrupt Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 13/43] target/hppa: Implement unaligned access trap Richard Henderson
2018-01-28 23:14 ` [Qemu-devel] [PULL v4 14/43] target/hppa: Use space registers in data operations Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 15/43] target/hppa: Avoid privilege level decrease during branches Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 16/43] target/hppa: Implement IASQ Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 17/43] target/hppa: Implement tlb_fill Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 18/43] target/hppa: Implement external interrupts Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 19/43] target/hppa: Implement the interval timer Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 20/43] target/hppa: Log unimplemented instructions Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 21/43] target/hppa: Implement I*TLBA and I*TLBP insns Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 22/43] target/hppa: Implement P*TLB and P*TLBE insns Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 23/43] target/hppa: Implement LDWA Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 24/43] target/hppa: Implement LPA Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 25/43] target/hppa: Implement LCI Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 26/43] target/hppa: Implement SYNCDMA insn Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 27/43] target/hppa: Implement halt and reset instructions Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 28/43] target/hppa: Optimize for flat addressing space Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 29/43] target/hppa: Add system registers to gdbstub Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 30/43] target/hppa: Add migration for the cpu Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 31/43] target/hppa: Implement B,GATE insn Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 32/43] target/hppa: Only use EXCP_DTLB_MISS Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 33/43] target/hppa: Increase number of temp regs Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 34/43] target/hppa: Fix comment Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 35/43] target/hppa: Implement LDSID for system mode Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 36/43] target/hppa: Implement a pause instruction Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 37/43] target/hppa: Implement STWA Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 38/43] target/hppa: Enable MTTCG Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 39/43] hw/hppa: Implement DINO system board Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 40/43] pc-bios: Add hppa-firmware.img and git submodule Richard Henderson
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 41/43] hw/hppa: Add MAINTAINERS entry Richard Henderson
2018-01-28 23:15 ` Richard Henderson [this message]
2018-01-28 23:15 ` [Qemu-devel] [PULL v4 43/43] target/hppa: Implement PROBE for system mode Richard Henderson
2018-01-28 23:59 ` [Qemu-devel] [PULL v4 00/43] hppa-softmmu no-reply
2018-01-29 13:12 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128231528.22719-43-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).