qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PULL 11/13] tests: Add migration xbzrle test
Date: Mon, 29 Jan 2018 13:09:30 +0100	[thread overview]
Message-ID: <20180129120932.12874-12-quintela@redhat.com> (raw)
In-Reply-To: <20180129120932.12874-1-quintela@redhat.com>

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
 tests/migration-test.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index 44c8860134..84f5bcf00a 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -533,6 +533,20 @@ static void deprecated_set_speed(QTestState *who, const char *value)
     migrate_check_parameter(who, "max-bandwidth", value);
 }
 
+static void deprecated_set_cache_size(QTestState *who, const char *value)
+{
+    QDict *rsp;
+    gchar *cmd;
+
+    cmd = g_strdup_printf("{ 'execute': 'migrate-set-cache-size',"
+                          "'arguments': { 'value': %s } }", value);
+    rsp = qtest_qmp(who, cmd);
+    g_free(cmd);
+    g_assert(qdict_haskey(rsp, "return"));
+    QDECREF(rsp);
+    migrate_check_parameter(who, "xbzrle-cache-size", value);
+}
+
 static void test_deprecated(void)
 {
     QTestState *from;
@@ -541,6 +555,7 @@ static void test_deprecated(void)
 
     deprecated_set_downtime(from, 0.12345);
     deprecated_set_speed(from, "12345");
+    deprecated_set_cache_size(from, "4096");
 
     qtest_quit(from);
 }
@@ -627,6 +642,54 @@ static void test_precopy_unix(void)
     g_free(uri);
 }
 
+static void test_xbzrle(const char *uri)
+{
+    QTestState *from, *to;
+
+    test_migrate_start(&from, &to, uri);
+
+    /* We want to pick a speed slow enough that the test completes
+     * quickly, but that it doesn't complete precopy even on a slow
+     * machine, so also set the downtime.
+     */
+    /* 1 ms should make it not converge*/
+    migrate_set_parameter(from, "downtime-limit", "1");
+    /* 1GB/s */
+    migrate_set_parameter(from, "max-bandwidth", "1000000000");
+
+    migrate_set_parameter(from, "xbzrle-cache-size", "33554432");
+
+    migrate_set_capability(from, "xbzrle", "true");
+    migrate_set_capability(to, "xbzrle", "true");
+    /* Wait for the first serial output from the source */
+    wait_for_serial("src_serial");
+
+    migrate(from, uri);
+
+    wait_for_migration_pass(from);
+
+    /* 300ms should converge */
+    migrate_set_parameter(from, "downtime-limit", "300");
+
+    if (!got_stop) {
+        qtest_qmp_eventwait(from, "STOP");
+    }
+    qtest_qmp_eventwait(to, "RESUME");
+
+    wait_for_serial("dest_serial");
+    wait_for_migration_complete(from);
+
+    test_migrate_end(from, to);
+}
+
+static void test_xbzrle_unix(void)
+{
+    char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
+
+    test_xbzrle(uri);
+    g_free(uri);
+}
+
 int main(int argc, char **argv)
 {
     char template[] = "/tmp/migration-test-XXXXXX";
@@ -649,6 +712,7 @@ int main(int argc, char **argv)
     qtest_add_func("/migration/precopy/unix", test_precopy_unix);
     qtest_add_func("/migration/deprecated", test_deprecated);
     qtest_add_func("/migration/postcopy/unix", test_postcopy);
+    qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix);
 
     ret = g_test_run();
 
-- 
2.14.3

  parent reply	other threads:[~2018-01-29 12:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 12:09 [Qemu-devel] [PULL 00/13] Migration PULL request Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 01/13] migration: Allow migrate_fd_connect to take an Error * Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 02/13] migration: Route errors down through migration_channel_connect Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 03/13] migration/savevm.c: set MAX_VM_CMD_PACKAGED_SIZE to 1ul << 32 Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 04/13] migration: use s->threshold_size inside migration_update_counters Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 05/13] migration: Drop current address parameter from save_zero_page() Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 06/13] tests: Remove deprecated migration tests commands Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 07/13] tests: Consolidate accelerators declaration Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 08/13] tests: Use consistent names for migration Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 09/13] tests: Add deprecated commands migration test Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 10/13] tests: Add migration precopy test Juan Quintela
2018-01-29 12:09 ` Juan Quintela [this message]
2018-01-29 12:09 ` [Qemu-devel] [PULL 12/13] tests: Create migrate-start-postcopy command Juan Quintela
2018-01-29 12:09 ` [Qemu-devel] [PULL 13/13] tests: Adjust sleeps for migration test Juan Quintela
2018-01-29 18:53 ` [Qemu-devel] [PULL 00/13] Migration PULL request Peter Maydell
2018-01-30  6:29   ` Juan Quintela
2018-02-01 13:10     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129120932.12874-12-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).