From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eg8Nz-0004VP-F8 for qemu-devel@nongnu.org; Mon, 29 Jan 2018 07:18:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eg8Nt-0000yT-A4 for qemu-devel@nongnu.org; Mon, 29 Jan 2018 07:18:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eg8Nt-0000y3-2l for qemu-devel@nongnu.org; Mon, 29 Jan 2018 07:18:01 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 51CA3B5AC for ; Mon, 29 Jan 2018 12:18:00 +0000 (UTC) From: Juan Quintela Date: Mon, 29 Jan 2018 13:17:49 +0100 Message-Id: <20180129121754.13033-1-quintela@redhat.com> Subject: [Qemu-devel] [PATCH v5 0/5] Add make check tests for Migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com Hi In v5: - Several patches moved to pull request - merge info_migrate and migration_tests only missing bit is tcp_port, needed for tcp tests - Rename tcp-port to x-tcp-port We will get better naming from David at some point, and we will use that bit - ppc: use inline code as suggested by lvivier Please, review. It is based on my previous pull request Based-on: 20180129120932.12874-1-quintela@redhat.com [v4] - rebase on top on v4 info_migrate patches - Tune sleeps to make patches fast - Create a deprecated test for deprecated commands (i.e. make peterxu happy) - create migrate_start_postcopy function - fix naming/sizes between power and x86 - cleanup comments to match code [v3] - No more tests for deprecated parameters. Now I only use migrate_set_parameter. If there is a deprecated command for that, we tests it there. - free "result" string, always good to return memory (Peter found it) - use the new tcp_port parameter from info migrate. So we are handling well the tcp case. - lots of code movement around to make everything consistent. - Several patches already integrated upstream. [v2] - to make review easier, I started renaming postcopy-test.c to migration-test.c - Did cleanups/refactoring there - Don't use global-qtest anymore - check that the parameters that we sent got really set - RFH: comrpress threads tests is not working for some weird reason. Using the same code on command line works. still investigating why. ToDoo: - tcp: after discussions with dave, we ended in conclusion that we need to use the 0 port and let the system gives us a free one But .... that means that we need to be able to get that port back somehow. "info migrate" woring on destination side? - compression threads. There is some weird interaction with the test hardness and every migration thread get waiting in a different semaphore. Investigating if it is a race/bug/whateverr - deprecated commands: There was a suggestion to make migrate_set_parameter look at the parameter name and test old/new depending on something. Not sure what to do here. - testing commands: Is there a way to launch qemu and just sent qmp/hmp commands without having to really run anything else? [v1] - add test for precopy for unix/tcp exec and fd to came, don't know how to test rdma without hardware - add tests using deprecated interfaces - add test for xbzrle Note to myself, there is no way to set the cache size with migraton_set_parameters - Add test for compress threads disabled on the series, right now it appears that compression is not working at all - Move postcopy to use new results Idea is to move it on top of migration-test.c, but first I want some reviews on basic idea Juan Quintela (5): migration: Create tcp_port parameter migration: Set the migration tcp port tests: Migration ppc now inlines its program tests: Add basic migration precopy tcp test [RFH] tests: Add migration compress threads tests hmp.c | 3 + migration/migration.c | 18 ++++++ migration/migration.h | 2 + migration/socket.c | 35 ++++++++++-- qapi/migration.json | 19 ++++++- tests/migration-test.c | 151 ++++++++++++++++++++++++++++++++++++------------- 6 files changed, 181 insertions(+), 47 deletions(-) -- 2.14.3