From: David Hildenbrand <david@redhat.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>, Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v3 06/18] s390x/flic: no need to call s390_io_interrupt() from flic
Date: Mon, 29 Jan 2018 13:56:11 +0100 [thread overview]
Message-ID: <20180129125623.21729-7-david@redhat.com> (raw)
In-Reply-To: <20180129125623.21729-1-david@redhat.com>
We can directly call the right function.
Suggested-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/intc/s390_flic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c
index bdc8ec7607..d6ed1d7380 100644
--- a/hw/intc/s390_flic.c
+++ b/hw/intc/s390_flic.c
@@ -108,6 +108,7 @@ static int qemu_s390_inject_airq(S390FLICState *fs, uint8_t type,
uint8_t isc, uint8_t flags)
{
QEMUS390FLICState *flic = QEMU_S390_FLIC(fs);
+ S390FLICStateClass *fsc = S390_FLIC_COMMON_GET_CLASS(fs);
bool flag = flags & S390_ADAPTER_SUPPRESSIBLE;
uint32_t io_int_word = (isc << 27) | IO_INT_WORD_AI;
@@ -116,7 +117,7 @@ static int qemu_s390_inject_airq(S390FLICState *fs, uint8_t type,
return 0;
}
- s390_io_interrupt(0, 0, 0, io_int_word);
+ fsc->inject_io(fs, 0, 0, 0, io_int_word);
if (flag && (flic->simm & AIS_MODE_MASK(isc))) {
flic->nimm |= AIS_MODE_MASK(isc);
--
2.14.3
next prev parent reply other threads:[~2018-01-29 12:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 12:56 [Qemu-devel] [PATCH v3 00/18] s390x: flic rework, tcg flic support and STSI David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 01/18] s390x/tcg: deliver multiple interrupts in a row David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 02/18] s390x/flic: simplify flic initialization David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 03/18] s390x/tcg: simplify lookup of flic David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 04/18] s390x/tcg: simplify machine check handling David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 05/18] s390x/flic: factor out injection of floating interrupts David Hildenbrand
2018-01-29 12:56 ` David Hildenbrand [this message]
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 07/18] s390x/tcg: tolerate wrong wakeups due to " David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 08/18] s390x/flic: make floating interrupts on TCG actually floating David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 09/18] s390x/tcg: implement TEST PENDING INTERRUPTION David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 10/18] s390x/flic: implement qemu_s390_clear_io_flic() David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 11/18] s390x/flic: optimize CPU wakeup for TCG David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 12/18] s390x: fix size + content of STSI blocks David Hildenbrand
2018-02-01 12:40 ` Cornelia Huck
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 13/18] s390x/tcg: STSI overhaul David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 14/18] s390x/tcg: remove SMP warning David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 15/18] configure: s390x supports mttcg now David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 16/18] s390x/tcg: cache the qemu flic in a central function David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 17/18] s390x/kvm: cache the kvm " David Hildenbrand
2018-01-29 12:56 ` [Qemu-devel] [PATCH v3 18/18] s390x/flic: cache the common flic class " David Hildenbrand
2018-02-01 13:28 ` [Qemu-devel] [PATCH v3 00/18] s390x: flic rework, tcg flic support and STSI Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129125623.21729-7-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).