qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image
Date: Mon, 29 Jan 2018 16:49:02 +0100	[thread overview]
Message-ID: <20180129154902.GJ6141@localhost.localdomain> (raw)
In-Reply-To: <20180124044216.12461-1-famz@redhat.com>

Am 24.01.2018 um 05:42 hat Fam Zheng geschrieben:
> The descriptor block in the image, which includes the CID to verify, has been
> invalid since the reference image was added. Since commit 9877860e7bd we report
> this error earlier than the "file too large", so 059.out mismatches.
> 
> Instead of fixing the output, we fix the image descriptor, because the code
> path we want to exercise is actually the invalid image size.
> 
> The binary change is generated along the operations of:
> 
>   $ bunzip2 afl9.vmdk.bz2
>   $ qemu-img create -f qcow2 fix.vmdk 1G

Sure about -f qcow2? :-)

>   $ dd if=afl9.vmdk.bz2 of=fix.vmdk bs=512 count=1 conv=notrunc
>   $ mv fix.vmdk afl9.vmdk
>   $ bzip2 afl9.vmdk
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/sample_images/afl9.vmdk.bz2 | Bin 178 -> 618 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)

I think you also want to revert 76bf133c in this patch, otherwise 059
fails after applying it.

Kevin

  reply	other threads:[~2018-01-29 15:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  4:42 [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image Fam Zheng
2018-01-29 15:49 ` Kevin Wolf [this message]
2018-01-30  6:26   ` Fam Zheng
  -- strict thread matches above, loose matches on Subject: below --
2018-01-30  6:25 Fam Zheng
2018-01-30 13:48 ` Eric Blake
2018-01-30 14:12   ` Fam Zheng
2018-01-30 16:26 ` Kevin Wolf
2018-01-31 18:58 ` Max Reitz
2018-02-01  0:55   ` Fam Zheng
2018-02-01 17:59     ` Max Reitz
2018-02-01 19:18       ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129154902.GJ6141@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=famz@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).