qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 12/12] vl: drop request_opengl variable
Date: Mon, 29 Jan 2018 17:24:08 +0100	[thread overview]
Message-ID: <20180129162408.415-13-kraxel@redhat.com> (raw)
In-Reply-To: <20180129162408.415-1-kraxel@redhat.com>

Switch over the one leftover user to qapi DisplayType.
The delete the unused request_opengl variable.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 vl.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/vl.c b/vl.c
index 827ab2a3b0..42867d60f8 100644
--- a/vl.c
+++ b/vl.c
@@ -135,7 +135,6 @@ static const char *data_dir[16];
 static int data_dir_idx;
 const char *bios_name = NULL;
 enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB;
-int request_opengl = -1;
 int display_opengl;
 const char* keyboard_layout = NULL;
 ram_addr_t ram_size;
@@ -2137,10 +2136,8 @@ static void parse_display(const char *p)
                 opts = nextopt;
                 dpy.has_gl = true;
                 if (strstart(opts, "on", &nextopt)) {
-                    request_opengl = 1;
                     dpy.gl = true;
                 } else if (strstart(opts, "off", &nextopt)) {
-                    request_opengl = 0;
                     dpy.gl = false;
                 } else {
                     goto invalid_sdl_args;
@@ -2165,7 +2162,6 @@ static void parse_display(const char *p)
         }
     } else if (strstart(p, "egl-headless", &opts)) {
 #ifdef CONFIG_OPENGL_DMABUF
-        request_opengl = 1;
         display_opengl = 1;
         dpy.type = DISPLAY_TYPE_EGL_HEADLESS;
 #else
@@ -2199,10 +2195,8 @@ static void parse_display(const char *p)
                 opts = nextopt;
                 dpy.has_gl = true;
                 if (strstart(opts, "on", &nextopt)) {
-                    request_opengl = 1;
                     dpy.gl = true;
                 } else if (strstart(opts, "off", &nextopt)) {
-                    request_opengl = 0;
                     dpy.gl = false;
                 } else {
                     goto invalid_gtk_args;
@@ -4356,7 +4350,7 @@ int main(int argc, char **argv, char **envp)
 
     qemu_console_early_init();
 
-    if (request_opengl == 1 && display_opengl == 0) {
+    if (dpy.has_gl && dpy.gl && display_opengl == 0) {
 #if defined(CONFIG_OPENGL)
         error_report("OpenGL is not supported by the display");
 #else
-- 
2.9.3

      parent reply	other threads:[~2018-01-29 16:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 16:23 [Qemu-devel] [PATCH v2 00/12] rework display initialization, part one Gerd Hoffmann
2018-01-29 16:23 ` [Qemu-devel] [PATCH v2 01/12] vl: deprecate -no-frame Gerd Hoffmann
2018-01-29 16:23 ` [Qemu-devel] [PATCH v2 02/12] vl: deprecate -alt-grab and -ctrl-grab Gerd Hoffmann
2018-01-29 16:23 ` [Qemu-devel] [PATCH v2 03/12] vl: rename DisplayType to LegacyDisplayType Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 04/12] gtk: add and use DisplayOptions + DisplayGTK Gerd Hoffmann
2018-01-31 18:02   ` Markus Armbruster
2018-01-31 18:37     ` Eric Blake
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 05/12] sdl: use DisplayOptions Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 06/12] vl: drop no_quit variable Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 07/12] egl-headless: use DisplayOptions Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 08/12] curses: " Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 09/12] cocoa: " Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 10/12] vl: drop full_screen variable Gerd Hoffmann
2018-01-29 16:24 ` [Qemu-devel] [PATCH v2 11/12] vl: drop display_type variable Gerd Hoffmann
2018-01-31 18:07   ` Markus Armbruster
2018-01-29 16:24 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129162408.415-13-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).