qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: Gal Hammer <ghammer@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/2] virtio: improve virtio devices initialization time
Date: Mon, 29 Jan 2018 18:47:17 +0100	[thread overview]
Message-ID: <20180129184717.68df3b33@bahia.lan> (raw)
In-Reply-To: <1517235657-22547-1-git-send-email-ghammer@redhat.com>

On Mon, 29 Jan 2018 16:20:55 +0200
Gal Hammer <ghammer@redhat.com> wrote:

> Using a cleanup callback function (Version 2 of this patches) in order to
> support transactions fails when the same event notifier fd was used by more
> than one Memory Region.
> 
> This time I ask the caller to do the event notifier cleanup by himself.
> 

Much better ! QEMU no longer aborts. Also I could observe a speed-up when
booting a fedora27 guest with 5 virtio-serial devices (max_ports=511), from
1m40s down to 1m10s. Impressive. :)

For all the patches in this series:

Reviewed-by: Greg Kurz <groug@kaod.org>

and

Tested-by: Greg Kurz <groug@kaod.org>

> Gal Hammer (2):
>   virtio: remove event notifier cleanup call on de-assign
>   virtio: improve virtio devices initialization time
> 
>  hw/block/dataplane/virtio-blk.c |  2 ++
>  hw/scsi/virtio-scsi-dataplane.c |  2 ++
>  hw/virtio/vhost.c               |  2 ++
>  hw/virtio/virtio-bus.c          | 14 ++++++++++----
>  hw/virtio/virtio.c              | 22 +++++++++++++++++++++-
>  include/hw/virtio/virtio-bus.h  |  2 ++
>  6 files changed, 39 insertions(+), 5 deletions(-)
> 

  parent reply	other threads:[~2018-01-29 17:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 14:20 [Qemu-devel] [PATCH v3 0/2] virtio: improve virtio devices initialization time Gal Hammer
2018-01-29 14:20 ` [Qemu-devel] [PATCH v3 1/2] virtio: remove event notifier cleanup call on de-assign Gal Hammer
2018-01-29 14:20 ` [Qemu-devel] [PATCH v3 2/2] virtio: improve virtio devices initialization time Gal Hammer
2018-02-08 19:05   ` Michael S. Tsirkin
2018-01-29 17:47 ` Greg Kurz [this message]
2018-01-30  8:33   ` [Qemu-devel] [PATCH v3 0/2] " Gal Hammer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129184717.68df3b33@bahia.lan \
    --to=groug@kaod.org \
    --cc=ghammer@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).