From: Alex Williamson <alex.williamson@redhat.com>
To: "Zhang, Tina" <tina.zhang@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [Qemu-devel] [RfC PATCH v2 4/5] vfio/display: core & wireup
Date: Wed, 31 Jan 2018 17:01:37 -0700 [thread overview]
Message-ID: <20180131170137.698bdcc4@w520.home> (raw)
In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C6B260A@SHSMSX101.ccr.corp.intel.com>
On Wed, 31 Jan 2018 23:42:49 +0000
"Zhang, Tina" <tina.zhang@intel.com> wrote:
> > @@ -2977,6 +2984,8 @@ static void vfio_instance_init(Object *obj) static
> > Property vfio_pci_dev_properties[] = {
> > DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host),
> > DEFINE_PROP_STRING("sysfsdev", VFIOPCIDevice, vbasedev.sysfsdev),
> > + DEFINE_PROP_ON_OFF_AUTO("display", VFIOPCIDevice,
> > + display, ON_OFF_AUTO_AUTO),
> Not "x-display"?
x-display would mean that it's an unsupported, experimental option that
libvirt wouldn't enable and downstreams might consider unsupported.
Don't we want this to be a supported feature enabled through libvirt?
Thanks,
Alex
next prev parent reply other threads:[~2018-02-01 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 12:12 [Qemu-devel] [RfC PATCH v2 0/5] vfio: add display support Gerd Hoffmann
2018-01-31 12:12 ` [Qemu-devel] [RfC PATCH v2 1/5] headers: update linux-headers/linux/vfio.h (intel-gvt kernel patches, v17) Gerd Hoffmann
2018-01-31 12:12 ` [Qemu-devel] [RfC PATCH v2 2/5] headers: add drm/drm_fourcc.h to standard-headers Gerd Hoffmann
2018-01-31 12:12 ` [Qemu-devel] [RfC PATCH v2 3/5] ui/pixman: add qemu_drm_format_to_pixman() Gerd Hoffmann
2018-01-31 12:12 ` [Qemu-devel] [RfC PATCH v2 4/5] vfio/display: core & wireup Gerd Hoffmann
2018-01-31 23:42 ` Zhang, Tina
2018-02-01 0:01 ` Alex Williamson [this message]
2018-01-31 12:12 ` [Qemu-devel] [RfC PATCH v2 5/5] vfio/display: adding region support Gerd Hoffmann
2018-01-31 20:20 ` [Qemu-devel] [RfC PATCH v2 0/5] vfio: add display support Alex Williamson
2018-02-01 8:24 ` Gerd Hoffmann
2018-02-03 19:10 ` Kirti Wankhede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131170137.698bdcc4@w520.home \
--to=alex.williamson@redhat.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=kwankhede@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).