qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: rth@twiddle.net, agraf@suse.de, david@redhat.com,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/2] s390x: support zpci in tcg
Date: Wed, 31 Jan 2018 19:17:40 +0100	[thread overview]
Message-ID: <20180131181742.2037-1-cohuck@redhat.com> (raw)

<blurb from last cover letter>
This patch set (available at git://github.com/cohuck/qemu pci-tcg)
wires up zpci under tcg. A guest started with

qemu-system-s390x -M s390-ccw-virtio,accel=tcg -cpu qemu,zpci=on -device virtio-net-pci (...)

and a 4.15 kernel in the guest (needed because the requirement for ais
was dropped with

commit 48070c73058be6de9c0d754d441ed7092dfc8f12
Author: Christian Borntraeger <borntraeger@de.ibm.com>
Date:   Mon Oct 30 14:38:58 2017 +0100

    s390/pci: do not require AIS facility

and we don't have a working ais with tcg yet), I get sensible output
out of lspci.
</blurb>

Looks much nicer now after implementing feedback from David (thanks!)

Changes RFC->v2:
- no need to check for the zpci feature in the helpers
- SIC does not set a condition code
- SIC also should not depend on zpci
- use tcg magic to improve the code in translate.c
- clear zpci feature from supported set for !CONFIG_PCI

Cornelia Huck (2):
  s390x/tcg: wire up pci instructions
  s390x/cpumodel: allow zpci features in qemu model

 target/s390x/cpu_models.c   |   6 +++
 target/s390x/gen-features.c |   3 ++
 target/s390x/helper.h       |   9 ++++
 target/s390x/insn-data.def  |  15 ++++++
 target/s390x/misc_helper.c  | 109 ++++++++++++++++++++++++++++++++++++++++++++
 target/s390x/translate.c    | 101 ++++++++++++++++++++++++++++++++++++++++
 6 files changed, 243 insertions(+)

-- 
2.13.6

             reply	other threads:[~2018-01-31 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 18:17 Cornelia Huck [this message]
2018-01-31 18:17 ` [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions Cornelia Huck
2018-02-01 10:00   ` Pierre Morel
2018-02-01 14:23     ` Cornelia Huck
2018-02-01 12:42   ` David Hildenbrand
2018-02-01 12:48     ` Cornelia Huck
2018-02-01 12:59       ` David Hildenbrand
2018-02-01 16:05         ` Cornelia Huck
2018-02-01 14:47   ` Cornelia Huck
2018-01-31 18:17 ` [Qemu-devel] [PATCH v2 2/2] s390x/cpumodel: allow zpci features in qemu model Cornelia Huck
2018-02-01 12:31   ` David Hildenbrand
2018-02-01 14:04     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180131181742.2037-1-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).