Re: [Qemu-devel] [PATCH] trace: avoid SystemTap "char const" warnings

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

On Thu, Feb 01, 2018 at 04:26:25PM +0000, Stefan Hajnoczi wrote:
> SystemTap's dtrace(1) produces the following warning when it encounters
> "char const" instead of "const char":
> 
>   Warning: /usr/bin/dtrace:trace-dtrace-root.dtrace:66: syntax error near:
>   probe flatview_destroy_rcu
> 
>   Warning: Proceeding as if --no-pyparsing was given.
> 
> This is a limitation in current SystemTap releases.  I have sent a patch
> upstream to accept "char const" since it is valid C:
> 
>   https://sourceware.org/ml/systemtap/2018-q1/msg00017.html
> 
> In QEMU we still wish to avoid warnings in the current SystemTap
> release.  It's simple enough to replace "char const" with "const char".
> 
> I'm not changing the documentation or implementing checks to prevent
> this from occurring again in the future.  The next release of SystemTap
> will hopefully resolve this issue.
> 
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/block/trace-events |  4 ++--
>  trace-events          | 12 ++++++------
>  2 files changed, 8 insertions(+), 8 deletions(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]