From: Peter Xu <peterx@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Devel Mailing List <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Windows balloon driver PFN issue
Date: Fri, 2 Feb 2018 18:11:40 +0800 [thread overview]
Message-ID: <20180202101140.GC4666@xz-mi> (raw)
In-Reply-To: <20180201144449-mutt-send-email-mst@kernel.org>
On Thu, Feb 01, 2018 at 02:48:20PM +0200, Michael S. Tsirkin wrote:
[...]
> > > > > PFN is GPA>>12. Do you have more than 1<<44 bytes of memory in this VM then?
> > > >
> > > > No. But isn't it still not good to drop the page at offset zero (and
> > > > drop it NNN times)?
> > >
> > > Absolutely - looks like a bug. I just don't know why does this happen.
> >
> > IMHO if we are using a PFN array like this:
> >
> > u64 pfn_array[];
> >
> > In the windows guest driver, then we'll see this (as mentioned
> > above). But for sure this is wild guess of mine.
>
> I don't see code like this anywhere in the windows balloon
> driver. It's here:
> https://github.com/virtio-win/kvm-guest-drivers-windows.git
Thanks for the pointer. I had a quick glance, the PFN array is
defined as:
PPFN_NUMBER pfns_table;
But I don't know what's sizeof(PPFN_NUMBER). :(
--
Peter Xu
next prev parent reply other threads:[~2018-02-02 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 9:28 [Qemu-devel] Windows balloon driver PFN issue Peter Xu
2018-01-31 14:03 ` Michael S. Tsirkin
2018-02-01 2:18 ` Peter Xu
2018-02-01 2:24 ` Michael S. Tsirkin
2018-02-01 2:33 ` Peter Xu
2018-02-01 12:48 ` Michael S. Tsirkin
2018-02-02 10:11 ` Peter Xu [this message]
[not found] ` <CAA2ifQzRFsZ_=mr9WrFjieTS7YuzQdz5xhoEWOE-5pWWBhBD7Q@mail.gmail.com>
2018-02-27 2:59 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202101140.GC4666@xz-mi \
--to=peterx@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).