From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehdQi-0006vr-1g for qemu-devel@nongnu.org; Fri, 02 Feb 2018 10:40:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehdNE-0007Bl-S6 for qemu-devel@nongnu.org; Fri, 02 Feb 2018 10:39:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48872) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ehdND-00079E-WD for qemu-devel@nongnu.org; Fri, 02 Feb 2018 10:35:32 -0500 Date: Fri, 2 Feb 2018 13:08:17 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180202130817.GE15403@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180129174132.108925-1-brijesh.singh@amd.com> <20180129174132.108925-14-brijesh.singh@amd.com> <20180201175802.GK2457@work-vm> <7c3c7a89-04ef-016e-c9a5-4f4d4be1c449@amd.com> <20180201200442.GQ2457@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180201200442.GQ2457@work-vm> Subject: Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Brijesh Singh , qemu-devel@nongnu.org, kvm@vger.kernel.org, Paolo Bonzini , Tom Lendacky , Peter Maydell , Richard Henderson , "Edgar E. Iglesias" , Eduardo Habkost , Stefan Hajnoczi , Eric Blake , "Michael S. Tsirkin" , Markus Armbruster On Thu, Feb 01, 2018 at 08:04:43PM +0000, Dr. David Alan Gilbert wrote: > * Brijesh Singh (brijesh.singh@amd.com) wrote: > > > > > > On 2/1/18 11:58 AM, Dr. David Alan Gilbert wrote: > > > * Brijesh Singh (brijesh.singh@amd.com) wrote: > > >> update 'info kvm' to display the memory encryption support. > > >> > > >> (qemu) info kvm > > >> kvm support: enabled > > >> memory encryption: disabled > > > As Markus said, this should be split qmp/hmp; but something else to > > > think about is whether this is a boolean or needs to be an enum; do > > > you have one version of encryption or are we going to need to flag up > > > versions or the features of the encryption? > > > > In future I could see us providing encrypted state status when we > > implement SEV-ES support, something like > > > > (qemu) info kvm > > kvm support: enabled > > memory encryption: enabled > > cpu register state: encrypted > > > > but so far I do not see need to provide the version string. If user > > wants to know the SEV version then it can open /dev/sev device to get > > platform status and more. > > Yes, I was worried a bit more about how general that was going to be > or whether we're collecting a lot of architecture specific fields here. > So I wondered, if it was an enum, whether that would be come: > > memory encryption: none > > memory encryption: SEV > > memory encryption: SEV-ES > > (I'm not too sure whether that's better or not, just a suggestion) I wonder if it is is even appropriate to have under 'info kvm', since 'info kvm' is architecture independant and SEV is specific to AMD x86_64 only. It might suggest an 'info sev' command is better ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|