From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: Recover block devices if failure in device state
Date: Tue, 6 Feb 2018 16:15:28 +0800 [thread overview]
Message-ID: <20180206081528.GE25932@xz-mi> (raw)
In-Reply-To: <20180205093941.21058-1-dgilbert@redhat.com>
On Mon, Feb 05, 2018 at 09:39:41AM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In e91d895 I added the new pause-before-switchover mechanism
> to allow migration completion to be delayed; this changes the
> last state prior to completion to MIGRATE_STATUS_DEVICE rather
> than MIGRATE_STATUS_ACTIVE.
>
> Fix the failure path in migration_completion to recover the block
> devices if it fails in MIGRATE_STATUS_DEVICE, not just the
> MIGRATE_STATUS_ACTIVE that it previously had.
>
> This corresponds to rh bz:
> https://bugzilla.redhat.com/show_bug.cgi?id=1538494
> whose symptom is an occasional source crash on a failed migration.
>
> Fixes: e91d8951d59d483f085f
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
prev parent reply other threads:[~2018-02-06 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 9:39 [Qemu-devel] [PATCH] migration: Recover block devices if failure in device state Dr. David Alan Gilbert (git)
2018-02-06 8:15 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206081528.GE25932@xz-mi \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).