qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com
Cc: peterx@redhat.com, lvivier@redhat.com, groug@kaod.org,
	ross.lagerwall@citrix.com, wei.w.wang@intel.com,
	danielhb@linux.vnet.ibm.com
Subject: [Qemu-devel] [PULL 09/14] tests: Add deprecated commands migration test
Date: Tue,  6 Feb 2018 15:49:31 +0000	[thread overview]
Message-ID: <20180206154936.13565-10-dgilbert@redhat.com> (raw)
In-Reply-To: <20180206154936.13565-1-dgilbert@redhat.com>

From: Juan Quintela <quintela@redhat.com>

We add deprecated commands on a new test, so we don't have to add it
on normal tests.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/migration-test.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index ac4a916169..2a0b651cd1 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -500,6 +500,51 @@ static void test_migrate_end(QTestState *from, QTestState *to)
     cleanup("dest_serial");
 }
 
+static void deprecated_set_downtime(QTestState *who, const double value)
+{
+    QDict *rsp;
+    gchar *cmd;
+    char *expected;
+    int64_t result_int;
+
+    cmd = g_strdup_printf("{ 'execute': 'migrate_set_downtime',"
+                          "'arguments': { 'value': %g } }", value);
+    rsp = qtest_qmp(who, cmd);
+    g_free(cmd);
+    g_assert(qdict_haskey(rsp, "return"));
+    QDECREF(rsp);
+    result_int = value * 1000L;
+    expected = g_strdup_printf("%" PRId64, result_int);
+    migrate_check_parameter(who, "downtime-limit", expected);
+    g_free(expected);
+}
+
+static void deprecated_set_speed(QTestState *who, const char *value)
+{
+    QDict *rsp;
+    gchar *cmd;
+
+    cmd = g_strdup_printf("{ 'execute': 'migrate_set_speed',"
+                          "'arguments': { 'value': %s } }", value);
+    rsp = qtest_qmp(who, cmd);
+    g_free(cmd);
+    g_assert(qdict_haskey(rsp, "return"));
+    QDECREF(rsp);
+    migrate_check_parameter(who, "max-bandwidth", value);
+}
+
+static void test_deprecated(void)
+{
+    QTestState *from;
+
+    from = qtest_start("");
+
+    deprecated_set_downtime(from, 0.12345);
+    deprecated_set_speed(from, "12345");
+
+    qtest_quit(from);
+}
+
 static void test_migrate(void)
 {
     char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
@@ -563,6 +608,7 @@ int main(int argc, char **argv)
     module_call_init(MODULE_INIT_QOM);
 
     qtest_add_func("/migration/postcopy/unix", test_migrate);
+    qtest_add_func("/migration/deprecated", test_deprecated);
 
     ret = g_test_run();
 
-- 
2.14.3

  parent reply	other threads:[~2018-02-06 15:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 15:49 [Qemu-devel] [PULL 00/14] migration queue Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 01/14] migration: Allow migrate_fd_connect to take an Error * Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 02/14] migration: Route errors down through migration_channel_connect Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 03/14] migration/savevm.c: set MAX_VM_CMD_PACKAGED_SIZE to 1ul << 32 Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 04/14] migration: use s->threshold_size inside migration_update_counters Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 05/14] migration: Drop current address parameter from save_zero_page() Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 06/14] tests: Remove deprecated migration tests commands Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 07/14] tests: Consolidate accelerators declaration Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 08/14] tests: Use consistent names for migration Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` Dr. David Alan Gilbert (git) [this message]
2018-02-06 15:49 ` [Qemu-devel] [PULL 10/14] tests: Create migrate-start-postcopy command Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 11/14] tests: Adjust sleeps for migration test Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 12/14] migration: Recover block devices if failure in device state Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 13/14] migration: Don't leak IO channels Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 14/14] migration: incoming postcopy advise sanity checks Dr. David Alan Gilbert (git)
2018-02-07 14:38 ` [Qemu-devel] [PULL 00/14] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180206154936.13565-10-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=danielhb@linux.vnet.ibm.com \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).