From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com
Cc: peterx@redhat.com, lvivier@redhat.com, groug@kaod.org,
ross.lagerwall@citrix.com, wei.w.wang@intel.com,
danielhb@linux.vnet.ibm.com
Subject: [Qemu-devel] [PULL 04/14] migration: use s->threshold_size inside migration_update_counters
Date: Tue, 6 Feb 2018 15:49:26 +0000 [thread overview]
Message-ID: <20180206154936.13565-5-dgilbert@redhat.com> (raw)
In-Reply-To: <20180206154936.13565-1-dgilbert@redhat.com>
From: Wei Wang <wei.w.wang@intel.com>
Fixes: b15df1ae50 ("migration: cleanup stats update into function")
The threshold size is changed to be recorded in s->threshold_size.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 1fbd304c66..44cbfb0ddd 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2169,7 +2169,6 @@ static void migration_update_counters(MigrationState *s,
int64_t current_time)
{
uint64_t transferred, time_spent;
- int64_t threshold_size;
double bandwidth;
if (current_time < s->iteration_start_time + BUFFER_DELAY) {
@@ -2179,7 +2178,7 @@ static void migration_update_counters(MigrationState *s,
transferred = qemu_ftell(s->to_dst_file) - s->iteration_initial_bytes;
time_spent = current_time - s->iteration_start_time;
bandwidth = (double)transferred / time_spent;
- threshold_size = bandwidth * s->parameters.downtime_limit;
+ s->threshold_size = bandwidth * s->parameters.downtime_limit;
s->mbps = (((double) transferred * 8.0) /
((double) time_spent / 1000.0)) / 1000.0 / 1000.0;
@@ -2199,7 +2198,7 @@ static void migration_update_counters(MigrationState *s,
s->iteration_initial_bytes = qemu_ftell(s->to_dst_file);
trace_migrate_transferred(transferred, time_spent,
- bandwidth, threshold_size);
+ bandwidth, s->threshold_size);
}
/* Migration thread iteration status */
--
2.14.3
next prev parent reply other threads:[~2018-02-06 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:49 [Qemu-devel] [PULL 00/14] migration queue Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 01/14] migration: Allow migrate_fd_connect to take an Error * Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 02/14] migration: Route errors down through migration_channel_connect Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 03/14] migration/savevm.c: set MAX_VM_CMD_PACKAGED_SIZE to 1ul << 32 Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` Dr. David Alan Gilbert (git) [this message]
2018-02-06 15:49 ` [Qemu-devel] [PULL 05/14] migration: Drop current address parameter from save_zero_page() Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 06/14] tests: Remove deprecated migration tests commands Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 07/14] tests: Consolidate accelerators declaration Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 08/14] tests: Use consistent names for migration Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 09/14] tests: Add deprecated commands migration test Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 10/14] tests: Create migrate-start-postcopy command Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 11/14] tests: Adjust sleeps for migration test Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 12/14] migration: Recover block devices if failure in device state Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 13/14] migration: Don't leak IO channels Dr. David Alan Gilbert (git)
2018-02-06 15:49 ` [Qemu-devel] [PULL 14/14] migration: incoming postcopy advise sanity checks Dr. David Alan Gilbert (git)
2018-02-07 14:38 ` [Qemu-devel] [PULL 00/14] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206154936.13565-5-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=danielhb@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).