qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: rnsastry@linux.vnet.ibm.com
Subject: [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg
Date: Wed,  7 Feb 2018 14:59:53 +0530	[thread overview]
Message-ID: <20180207092953.93162-1-rnsastry@linux.vnet.ibm.com> (raw)

Detected by by Coverity (CID 1385425)
with out this break statement the assigned value of 'tgt_len' at
line 1824 will be replaced by value of 'tgt_len' at line 1830.

Signed-off-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
---
 linux-user/syscall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 74378947f0..3ecd533880 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1826,6 +1826,7 @@ static inline abi_long host_to_target_cmsg(struct target_msghdr *target_msgh,
             default:
                 break;
             }
+        break;
         default:
             tgt_len = len;
             break;
-- 
2.14.3 (Apple Git-98)

             reply	other threads:[~2018-02-07  9:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  9:29 Nageswara R Sastry [this message]
2018-02-07  9:49 ` [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg no-reply
2018-02-07 13:57   ` Laurent Vivier
2018-02-08  5:33     ` Nageswara Sastry
2018-02-08  9:56     ` Nageswara R Sastry
2018-02-15 14:47       ` Laurent Vivier
2018-02-16  9:42         ` Nageswara R Sastry
2018-02-07  9:58 ` no-reply
  -- strict thread matches above, loose matches on Subject: below --
2018-02-07  6:26 Nageswara R Sastry
2018-02-07 14:53 ` no-reply
2018-02-07 15:02 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180207092953.93162-1-rnsastry@linux.vnet.ibm.com \
    --to=rnsastry@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).