From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejM4b-0002jr-Cs for qemu-devel@nongnu.org; Wed, 07 Feb 2018 04:31:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejM4W-0006iS-UM for qemu-devel@nongnu.org; Wed, 07 Feb 2018 04:31:25 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ejM4W-0006i8-Ja for qemu-devel@nongnu.org; Wed, 07 Feb 2018 04:31:20 -0500 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w179V7YS025278 for ; Wed, 7 Feb 2018 04:31:19 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fyxsa8ax9-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 07 Feb 2018 04:31:13 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Feb 2018 09:30:02 -0000 From: Nageswara R Sastry Date: Wed, 7 Feb 2018 14:59:53 +0530 Message-Id: <20180207092953.93162-1-rnsastry@linux.vnet.ibm.com> Subject: [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: rnsastry@linux.vnet.ibm.com Detected by by Coverity (CID 1385425) with out this break statement the assigned value of 'tgt_len' at line 1824 will be replaced by value of 'tgt_len' at line 1830. Signed-off-by: Nageswara R Sastry --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 74378947f0..3ecd533880 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1826,6 +1826,7 @@ static inline abi_long host_to_target_cmsg(struct target_msghdr *target_msgh, default: break; } + break; default: tgt_len = len; break; -- 2.14.3 (Apple Git-98)