From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
boost.lists@gmail.com, quintela@redhat.com,
ciro.santilli@gmail.com, jasowang@redhat.com, mst@redhat.com,
zuban32s@gmail.com, maria.klimushenkova@ispras.ru,
dovgaluk@ispras.ru, kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
thomas.dullien@googlemail.com, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: [Qemu-devel] [RFC PATCH v6 14/20] replay: don't destroy mutex at exit
Date: Wed, 07 Feb 2018 15:05:12 +0300 [thread overview]
Message-ID: <20180207120511.5389.61705.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20180207120353.5389.54531.stgit@pasha-VirtualBox>
Replay mutex is held by vCPU thread and destroy function is called
from atexit of the main thread. Therefore we cannot destroy it safely.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
---
replay/replay.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/replay/replay.c b/replay/replay.c
index a3ab3bb..585c5de 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -356,7 +356,6 @@ void replay_finish(void)
replay_snapshot = NULL;
replay_finish_events();
- replay_mutex_destroy();
}
void replay_add_blocker(Error *reason)
next prev parent reply other threads:[~2018-02-07 12:05 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 12:03 [Qemu-devel] [RFC PATCH v6 00/20] replay additions Pavel Dovgalyuk
2018-02-07 12:03 ` [Qemu-devel] [RFC PATCH v6 01/20] cpu-exec: fix exception_index handling Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 02/20] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 03/20] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 04/20] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 05/20] replay: fix processing async events Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 06/20] replay: fixed replay_enable_events Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 07/20] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 08/20] replay: added replay log format description Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 09/20] replay: save prior value of the host clock Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 10/20] replay/replay.c: bump REPLAY_VERSION again Pavel Dovgalyuk
2018-02-07 12:04 ` [Qemu-devel] [RFC PATCH v6 11/20] replay/replay-internal.c: track holding of replay_lock Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 12/20] replay: make locking visible outside replay code Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 13/20] replay: push replay_mutex_lock up the call tree Pavel Dovgalyuk
2018-02-07 12:05 ` Pavel Dovgalyuk [this message]
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 15/20] replay: check return values of fwrite Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 16/20] replay: avoid recursive call of checkpoints Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 17/20] scripts/replay-dump.py: replay log dumper Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 18/20] replay: don't process async events when warping the clock Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 19/20] replay: save vmstate of the asynchronous events Pavel Dovgalyuk
2018-02-07 12:05 ` [Qemu-devel] [RFC PATCH v6 20/20] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-02-07 12:15 ` [Qemu-devel] [RFC PATCH v6 00/20] replay additions Ciro Santilli
2018-02-07 12:38 ` Pavel Dovgalyuk
2018-02-08 7:35 ` Ciro Santilli
2018-02-10 0:09 ` Ciro Santilli
2018-02-12 5:47 ` Pavel Dovgalyuk
2018-02-13 5:58 ` Ciro Santilli
2018-02-13 6:50 ` Pavel Dovgalyuk
2018-02-13 9:07 ` Ciro Santilli
2018-02-13 9:58 ` Pavel Dovgalyuk
2018-02-13 10:26 ` Pavel Dovgalyuk
2018-02-13 10:49 ` Peter Maydell
2018-02-13 10:52 ` Pavel Dovgalyuk
2018-02-13 11:37 ` Ciro Santilli
2018-02-13 12:13 ` Pavel Dovgalyuk
2018-02-14 12:39 ` Pavel Dovgalyuk
2018-02-19 8:02 ` Pavel Dovgalyuk
2018-02-19 11:15 ` Ciro Santilli
2018-02-20 9:46 ` Pavel Dovgalyuk
2018-02-20 23:59 ` Ciro Santilli
2018-02-21 6:41 ` Pavel Dovgalyuk
2018-02-21 22:40 ` Ciro Santilli
2018-02-22 7:06 ` Pavel Dovgalyuk
2018-02-22 7:10 ` Pavel Dovgalyuk
2018-02-22 17:52 ` Ciro Santilli
2018-02-12 6:53 ` Pavel Dovgalyuk
2018-02-14 6:21 ` Ciro Santilli
2018-02-14 9:20 ` Pavel Dovgalyuk
2018-02-07 13:38 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207120511.5389.61705.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).