From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cpu: drop unnecessary NULL check and cpu_common_class_by_name()
Date: Wed, 7 Feb 2018 13:25:52 -0200 [thread overview]
Message-ID: <20180207152552.GK3291@localhost.localdomain> (raw)
In-Reply-To: <1518013857-4372-1-git-send-email-imammedo@redhat.com>
On Wed, Feb 07, 2018 at 03:30:57PM +0100, Igor Mammedov wrote:
> both do nothing as for the first all callers
> parse_cpu_model() and qmp_query_cpu_model_()
> should provide non NULL value, so just abort if it's not so.
>
> While at it drop cpu_common_class_by_name() which is not need
> any more as every target has CPUClass::class_by_name callback
> by now, though abort in case a new arch will forget to define one.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2018-02-07 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 10:40 [Qemu-devel] [PATCH v4 0/5] generalize parsing of cpu_model (part 4) Igor Mammedov
2018-02-07 10:40 ` [Qemu-devel] [PATCH v4 1/5] nios2: 10m50_devboard: replace cpu_model with cpu_type Igor Mammedov
2018-02-07 10:40 ` [Qemu-devel] [PATCH v4 2/5] tests: add machine 'none' with -cpu test Igor Mammedov
2018-02-07 10:40 ` [Qemu-devel] [PATCH v4 3/5] cpu: add CPU_RESOLVING_TYPE macro Igor Mammedov
2018-02-07 12:57 ` Eduardo Habkost
2018-02-07 14:30 ` [Qemu-devel] [PATCH] cpu: drop unnecessary NULL check and cpu_common_class_by_name() Igor Mammedov
2018-02-07 15:25 ` Eduardo Habkost [this message]
2018-03-12 17:56 ` [Qemu-devel] [PATCH] fixup! cpu: add CPU_RESOLVING_TYPE macro Eduardo Habkost
2018-02-07 10:40 ` [Qemu-devel] [PATCH v4 4/5] Use cpu_create(type) instead of cpu_init(cpu_model) Igor Mammedov
2018-02-07 10:40 ` [Qemu-devel] [PATCH v4 5/5] cpu: get rid of unused cpu_init() defines Igor Mammedov
2018-02-07 13:10 ` [Qemu-devel] [PATCH v4 0/5] generalize parsing of cpu_model (part 4) Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207152552.GK3291@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).