qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, eblake@redhat.com, ehabkost@redhat.com,
	berrange@redhat.com, mihajlov@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 0/2] qmp: add query-cpus-fast
Date: Wed,  7 Feb 2018 12:50:12 -0500	[thread overview]
Message-ID: <20180207175014.11157-1-lcapitulino@redhat.com> (raw)


We've recently debugged a huge performance degradation we were getting
on a latency sensitive workload down to the fact that libvirt is
issuing query-cpus. As it turns out, query-cpus always interrupts all
vCPU threads so that they can run ioctl to collect a number of register
information, most of which are not even used by query-cpus at all.

This series adds a new command called query-cpus-fast, which returns
the most relevant information returned by query-cpus without having
to interrupt vCPU threads. This series also updates query-cpus
documentation to advise against its use in production.

More details in individual patches.

Luiz Capitulino (2):
  qmp: add query-cpus-fast
  qmp: document query-cpus performance issue

 cpus.c               | 44 ++++++++++++++++++++++++++++++
 hmp-commands-info.hx | 14 ++++++++++
 hmp.c                | 24 +++++++++++++++++
 hmp.h                |  1 +
 qapi-schema.json     | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 158 insertions(+)

-- 
2.14.3

             reply	other threads:[~2018-02-07 17:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 17:50 Luiz Capitulino [this message]
2018-02-07 17:50 ` [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast Luiz Capitulino
2018-02-07 18:49   ` Eric Blake
2018-02-08  7:41   ` Viktor Mihajlovski
2018-02-08 10:13     ` Viktor Mihajlovski
2018-02-08 13:59     ` Luiz Capitulino
2018-02-08 19:59   ` Eduardo Habkost
2018-02-08 20:59     ` Eric Blake
2018-02-08 21:41       ` Eduardo Habkost
2018-02-09  8:13         ` Viktor Mihajlovski
2018-02-07 17:50 ` [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue Luiz Capitulino
2018-02-07 18:50   ` Eric Blake
2018-02-07 19:14     ` Luiz Capitulino
2018-02-08  9:29   ` Daniel P. Berrangé
2018-02-08 14:00     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180207175014.11157-1-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mihajlov@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).