From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexey Perevalov <a.perevalov@samsung.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH v6 14/28] migration: wakeup dst ram-load-thread for recover
Date: Thu, 8 Feb 2018 18:31:18 +0800 [thread overview]
Message-ID: <20180208103132.28452-15-peterx@redhat.com> (raw)
In-Reply-To: <20180208103132.28452-1-peterx@redhat.com>
On the destination side, we cannot wake up all the threads when we got
reconnected. The first thing to do is to wake up the main load thread,
so that we can continue to receive valid messages from source again and
reply when needed.
At this point, we switch the destination VM state from postcopy-paused
back to postcopy-recover.
Now we are finally ready to do the resume logic.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 30 ++++++++++++++++++++++++++++--
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 6c5e422616..6503b26386 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -427,8 +427,34 @@ static void migration_incoming_process(void)
void migration_fd_process_incoming(QEMUFile *f)
{
- migration_incoming_setup(f);
- migration_incoming_process();
+ MigrationIncomingState *mis = migration_incoming_get_current();
+
+ if (mis->state == MIGRATION_STATUS_POSTCOPY_PAUSED) {
+ /* Resumed from a paused postcopy migration */
+
+ mis->from_src_file = f;
+ /* Postcopy has standalone thread to do vm load */
+ qemu_file_set_blocking(f, true);
+
+ /* Re-configure the return path */
+ mis->to_src_file = qemu_file_get_return_path(f);
+
+ migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_PAUSED,
+ MIGRATION_STATUS_POSTCOPY_RECOVER);
+
+ /*
+ * Here, we only wake up the main loading thread (while the
+ * fault thread will still be waiting), so that we can receive
+ * commands from source now, and answer it if needed. The
+ * fault thread will be woken up afterwards until we are sure
+ * that source is ready to reply to page requests.
+ */
+ qemu_sem_post(&mis->postcopy_pause_sem_dst);
+ } else {
+ /* New incoming migration */
+ migration_incoming_setup(f);
+ migration_incoming_process();
+ }
}
void migration_ioc_process_incoming(QIOChannel *ioc)
--
2.14.3
next prev parent reply other threads:[~2018-02-08 10:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 10:31 [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 01/28] migration: better error handling with QEMUFile Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 02/28] migration: reuse mis->userfault_quit_fd Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 03/28] migration: provide postcopy_fault_thread_notify() Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 04/28] migration: new postcopy-pause state Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 05/28] migration: implement "postcopy-pause" src logic Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 06/28] migration: allow dst vm pause on postcopy Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 07/28] migration: allow src return path to pause Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 08/28] migration: allow send_rq to fail Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 09/28] migration: allow fault thread to pause Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 10/28] qmp: hmp: add migrate "resume" option Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 11/28] migration: pass MigrationState to migrate_init() Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 12/28] migration: rebuild channel on source Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 13/28] migration: new state "postcopy-recover" Peter Xu
2018-02-08 10:31 ` Peter Xu [this message]
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 15/28] migration: new cmd MIG_CMD_RECV_BITMAP Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 16/28] migration: new message MIG_RP_MSG_RECV_BITMAP Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 17/28] migration: new cmd MIG_CMD_POSTCOPY_RESUME Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 18/28] migration: new message MIG_RP_MSG_RESUME_ACK Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 19/28] migration: introduce SaveVMHandlers.resume_prepare Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 20/28] migration: synchronize dirty bitmap for resume Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 21/28] migration: setup ramstate " Peter Xu
2018-02-13 18:17 ` Dr. David Alan Gilbert
2018-02-14 4:20 ` Peter Xu
2018-02-14 18:40 ` Dr. David Alan Gilbert
2018-02-22 7:34 ` Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 22/28] migration: final handshake for the resume Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 23/28] migration: init dst in migration_object_init too Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 24/28] io: let watcher of the channel run in same ctx Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 25/28] qmp/migration: new command migrate-recover Peter Xu
2018-02-13 18:56 ` Dr. David Alan Gilbert
2018-02-14 4:30 ` Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 26/28] hmp/migration: add migrate_recover command Peter Xu
2018-02-13 19:45 ` Dr. David Alan Gilbert
2018-02-14 4:48 ` Peter Xu
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause Peter Xu
2018-02-13 20:11 ` Dr. David Alan Gilbert
2018-02-14 4:56 ` Peter Xu
2018-02-14 18:56 ` Dr. David Alan Gilbert
2018-02-22 7:43 ` Peter Xu
2018-02-28 20:14 ` Dr. David Alan Gilbert
2018-03-13 9:13 ` Peter Xu
2018-03-13 12:35 ` Dr. David Alan Gilbert
2018-03-13 15:57 ` Peter Xu
2018-03-13 16:05 ` Dr. David Alan Gilbert
2018-02-08 10:31 ` [Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause command Peter Xu
2018-02-13 20:14 ` Dr. David Alan Gilbert
2018-02-08 10:38 ` [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery Peter Xu
2018-02-08 11:25 ` no-reply
2018-02-09 6:07 ` Peter Xu
2018-02-09 6:19 ` Fam Zheng
2018-02-08 11:27 ` no-reply
2018-02-08 11:28 ` no-reply
2018-02-08 11:30 ` no-reply
2018-02-08 12:18 ` no-reply
2018-02-09 6:28 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208103132.28452-15-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=a.perevalov@samsung.com \
--cc=aarcange@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).