From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
mst@redhat.com, quintela@redhat.com, pbonzini@redhat.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support
Date: Thu, 8 Feb 2018 20:15:24 +0000 [thread overview]
Message-ID: <20180208201523.GE2326@work-vm> (raw)
In-Reply-To: <1517915299-15349-1-git-send-email-wei.w.wang@intel.com>
* Wei Wang (wei.w.wang@intel.com) wrote:
> This is the deivce part implementation to add a new feature,
> VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device
> receives the guest free page hints from the driver and clears the
> corresponding bits in the dirty bitmap, so that those free pages are
> not transferred by the migration thread to the destination.
>
> Please see the driver patch link for test results:
> https://lkml.org/lkml/2018/2/4/60
Hi Wei,
I'll look at the code a bit more - but first some more basic
questions on that lkml post:
a) The idle guest time thing is a nice result; can you just state
what the host was, speed of connection, and what other options
you were using?
b) The workload test, the one with the kernel compile; you list
the kernel compile time but don't mention any changes in the
migration times of the ping-pong; can you give those times as
well?
c) What's your real workload that this is aimed at?
Is it really for people migrating idle VMs - or do you have some
NFV application in mind, if so why not include a figure for
those?
Thanks,
Dave
> ChangeLog:
> v1->v2:
> 1) virtio-balloon
> - use subsections to save free_page_report_cmd_id;
> - poll the free page vq after sending a cmd id to the driver;
> - change the free page vq size to VIRTQUEUE_MAX_SIZE;
> - virtio_balloon_poll_free_page_hints: handle the corner case
> that the free page block reported from the driver may cross
> the RAMBlock boundary.
> 2) migration/ram.c
> - use balloon_free_page_poll to start the optimization
>
> Wei Wang (3):
> virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
> migration: use the free page reporting feature from balloon
> virtio-balloon: add a timer to limit the free page report waiting time
>
> balloon.c | 39 ++--
> hw/virtio/virtio-balloon.c | 227 ++++++++++++++++++++++--
> hw/virtio/virtio-pci.c | 3 +
> include/hw/virtio/virtio-balloon.h | 15 +-
> include/migration/misc.h | 3 +
> include/standard-headers/linux/virtio_balloon.h | 7 +
> include/sysemu/balloon.h | 12 +-
> migration/ram.c | 34 +++-
> 8 files changed, 307 insertions(+), 33 deletions(-)
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-02-08 20:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 11:08 [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support Wei Wang
2018-02-06 11:08 ` [Qemu-devel] [PATCH v2 1/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-02-07 1:04 ` Michael S. Tsirkin
2018-03-02 9:32 ` Wei Wang
2018-02-09 12:06 ` Dr. David Alan Gilbert
2018-02-06 11:08 ` [Qemu-devel] [PATCH v2 2/3] migration: use the free page reporting feature from balloon Wei Wang
2018-02-06 23:57 ` Michael S. Tsirkin
2018-02-08 3:54 ` Wei Wang
2018-02-09 11:50 ` Dr. David Alan Gilbert
2018-02-26 5:07 ` Wei Wang
2018-02-26 9:22 ` Wang, Wei W
2018-02-06 11:08 ` [Qemu-devel] [PATCH v2 3/3] virtio-balloon: add a timer to limit the free page report waiting time Wei Wang
2018-02-06 23:43 ` Michael S. Tsirkin
2018-02-09 12:15 ` Dr. David Alan Gilbert
2018-02-26 4:35 ` Wei Wang
2018-02-27 0:50 ` Michael S. Tsirkin
2018-02-27 10:10 ` Wei Wang
2018-02-27 13:08 ` Liang Li
2018-02-28 10:33 ` Wei Wang
2018-02-27 10:34 ` Dr. David Alan Gilbert
2018-02-28 10:37 ` Wei Wang
2018-02-07 0:02 ` [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support Michael S. Tsirkin
2018-02-08 5:38 ` Wei Wang
2018-02-08 20:15 ` Dr. David Alan Gilbert [this message]
2018-02-09 3:10 ` Wei Wang
2018-02-09 10:53 ` Dr. David Alan Gilbert
2018-02-26 4:42 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208201523.GE2326@work-vm \
--to=dgilbert@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu0@gmail.com \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).