[Qemu-devel] [PULL 0/1] Travis speed-up

[Qemu-devel] [PULL 0/1] Travis speed-up

[Alex Bennée]

The following changes since commit 04bb7fe2bf55bdf66d5b7a5a719b40bbb4048178:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180208' into staging (2018-02-08 17:41:15 +0000)

are available in the Git repository at:

  https://github.com/stsquad/qemu.git tags/pull-travis-speedup-090218-1

for you to fetch changes up to 04200a1674bfc20784f1fc105cbc22bd9be779e8:

  .travis.yml: add --disable-linux-user for some jobs (2018-02-09 14:09:24 +0000)

----------------------------------------------------------------
One patch to mitigate Travis timeouts

----------------------------------------------------------------
Alex Bennée (1):
      .travis.yml: add --disable-linux-user for some jobs

 .travis.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.15.1

[Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

[Alex Bennée]

The modules and co-routine builds are only really relevant to softmmu
builds and regularly timeout on Travis. Let's disable linux-user
builds here for more headroom.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

diff --git a/.travis.yml b/.travis.yml
index 01a57399b5..0dd5020552 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -52,9 +52,9 @@ env:
     - CONFIG=""
     - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
     - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
-    - CONFIG="--enable-modules"
-    - CONFIG="--with-coroutine=ucontext"
-    - CONFIG="--with-coroutine=sigaltstack"
+    - CONFIG="--enable-modules --disable-linux-user"
+    - CONFIG="--with-coroutine=ucontext --disable-linux-user"
+    - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
 git:
   # we want to do this ourselves
   submodules: false
-- 
2.15.1

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

[Daniel P. Berrangé]

On Fri, Feb 09, 2018 at 02:15:14PM +0000, Alex Bennée wrote:
> The modules and co-routine builds are only really relevant to softmmu
> builds and regularly timeout on Travis. Let's disable linux-user
> builds here for more headroom.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> 
> diff --git a/.travis.yml b/.travis.yml
> index 01a57399b5..0dd5020552 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -52,9 +52,9 @@ env:
>      - CONFIG=""
>      - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
> -    - CONFIG="--enable-modules"
> -    - CONFIG="--with-coroutine=ucontext"
> -    - CONFIG="--with-coroutine=sigaltstack"
> +    - CONFIG="--enable-modules --disable-linux-user"
> +    - CONFIG="--with-coroutine=ucontext --disable-linux-user"
> +    - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"

Since this merged, the 4th, 5th & 6th jobs are now reliably completing in
time, but the 1st and 3rd jobs are hitting timeouts on the majority of
runs :-(

We've already got a lot of jobs, but for sake of reliability should we
consider splitting the 1st & 3rd jobs. Add --disable-linux-user to both
of the existing jobs, and then adding 2 new jobs with --disable-system
and --disable-tools set ?

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

[Paolo Bonzini]

On 13/03/2018 14:40, Daniel P. Berrangé wrote:
>> @@ -52,9 +52,9 @@ env:
>>      - CONFIG=""
>>      - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
>>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
>> -    - CONFIG="--enable-modules"
>> -    - CONFIG="--with-coroutine=ucontext"
>> -    - CONFIG="--with-coroutine=sigaltstack"
>> +    - CONFIG="--enable-modules --disable-linux-user"
>> +    - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>> +    - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
> Since this merged, the 4th, 5th & 6th jobs are now reliably completing in
> time, but the 1st and 3rd jobs are hitting timeouts on the majority of
> runs :-(
> 
> We've already got a lot of jobs, but for sake of reliability should we
> consider splitting the 1st & 3rd jobs. Add --disable-linux-user to both
> of the existing jobs, and then adding 2 new jobs with --disable-system
> and --disable-tools set ?

Out of curiosity, why do we need the third job at all?  And
--enable-trace-backends=log is the default, so "--enable-debug
--enable-debug-tcg" should be enough.

Paolo

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

[Daniel P. Berrangé]

On Tue, Mar 13, 2018 at 02:49:42PM +0100, Paolo Bonzini wrote:
> On 13/03/2018 14:40, Daniel P. Berrangé wrote:
> >> @@ -52,9 +52,9 @@ env:
> >>      - CONFIG=""
> >>      - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
> >>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
> >> -    - CONFIG="--enable-modules"
> >> -    - CONFIG="--with-coroutine=ucontext"
> >> -    - CONFIG="--with-coroutine=sigaltstack"
> >> +    - CONFIG="--enable-modules --disable-linux-user"
> >> +    - CONFIG="--with-coroutine=ucontext --disable-linux-user"
> >> +    - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
> > Since this merged, the 4th, 5th & 6th jobs are now reliably completing in
> > time, but the 1st and 3rd jobs are hitting timeouts on the majority of
> > runs :-(
> > 
> > We've already got a lot of jobs, but for sake of reliability should we
> > consider splitting the 1st & 3rd jobs. Add --disable-linux-user to both
> > of the existing jobs, and then adding 2 new jobs with --disable-system
> > and --disable-tools set ?
> 
> Out of curiosity, why do we need the third job at all?  And
> --enable-trace-backends=log is the default, so "--enable-debug
> --enable-debug-tcg" should be enough.

Presumably that is intended to validate that code still builds correctly
when various optional features are turned off, by exercising different
codepaths in the countless #ifdef HAVE_$FEATURE  conditionals we have.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

[Alex Bennée]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Fri, Feb 09, 2018 at 02:15:14PM +0000, Alex Bennée wrote:
>> The modules and co-routine builds are only really relevant to softmmu
>> builds and regularly timeout on Travis. Let's disable linux-user
>> builds here for more headroom.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 01a57399b5..0dd5020552 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -52,9 +52,9 @@ env:
>>      - CONFIG=""
>>      - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
>>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
>> -    - CONFIG="--enable-modules"
>> -    - CONFIG="--with-coroutine=ucontext"
>> -    - CONFIG="--with-coroutine=sigaltstack"
>> +    - CONFIG="--enable-modules --disable-linux-user"
>> +    - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>> +    - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
>
> Since this merged, the 4th, 5th & 6th jobs are now reliably completing in
> time, but the 1st and 3rd jobs are hitting timeouts on the majority of
> runs :-(

Yeah it's certainly a problem as QEMU has grown. The original
.travis.yml split things up across architecture lines but we removed
that in favour of "feature" selection.

> We've already got a lot of jobs, but for sake of reliability should we
> consider splitting the 1st & 3rd jobs. Add --disable-linux-user to both
> of the existing jobs, and then adding 2 new jobs with --disable-system
> and --disable-tools set ?

Good idea. I don't suppose you've already tried this?

>
> Regards,
> Daniel


--
Alex Bennée

Re: [Qemu-devel] [PULL 1/1] .travis.yml: add --disable-linux-user for some jobs

[Daniel P. Berrangé]

On Tue, Mar 13, 2018 at 02:02:54PM +0000, Alex Bennée wrote:
> 
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > On Fri, Feb 09, 2018 at 02:15:14PM +0000, Alex Bennée wrote:
> >> The modules and co-routine builds are only really relevant to softmmu
> >> builds and regularly timeout on Travis. Let's disable linux-user
> >> builds here for more headroom.
> >>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> >>
> >> diff --git a/.travis.yml b/.travis.yml
> >> index 01a57399b5..0dd5020552 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -52,9 +52,9 @@ env:
> >>      - CONFIG=""
> >>      - CONFIG="--enable-debug --enable-debug-tcg --enable-trace-backends=log"
> >>      - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-uuid --disable-libusb"
> >> -    - CONFIG="--enable-modules"
> >> -    - CONFIG="--with-coroutine=ucontext"
> >> -    - CONFIG="--with-coroutine=sigaltstack"
> >> +    - CONFIG="--enable-modules --disable-linux-user"
> >> +    - CONFIG="--with-coroutine=ucontext --disable-linux-user"
> >> +    - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
> >
> > Since this merged, the 4th, 5th & 6th jobs are now reliably completing in
> > time, but the 1st and 3rd jobs are hitting timeouts on the majority of
> > runs :-(
> 
> Yeah it's certainly a problem as QEMU has grown. The original
> .travis.yml split things up across architecture lines but we removed
> that in favour of "feature" selection.
> 
> > We've already got a lot of jobs, but for sake of reliability should we
> > consider splitting the 1st & 3rd jobs. Add --disable-linux-user to both
> > of the existing jobs, and then adding 2 new jobs with --disable-system
> > and --disable-tools set ?
> 
> Good idea. I don't suppose you've already tried this?

No, I've not gone beyond quickly writing this previous mail  :-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PULL 0/1] Travis speed-up

[Peter Maydell]

On 9 February 2018 at 14:15, Alex Bennée <alex.bennee@linaro.org> wrote:
> The following changes since commit 04bb7fe2bf55bdf66d5b7a5a719b40bbb4048178:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180208' into staging (2018-02-08 17:41:15 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/stsquad/qemu.git tags/pull-travis-speedup-090218-1
>
> for you to fetch changes up to 04200a1674bfc20784f1fc105cbc22bd9be779e8:
>
>   .travis.yml: add --disable-linux-user for some jobs (2018-02-09 14:09:24 +0000)
>
> ----------------------------------------------------------------
> One patch to mitigate Travis timeouts
>
> ----------------------------------------------------------------
> Alex Bennée (1):
>       .travis.yml: add --disable-linux-user for some jobs
>
>  .travis.yml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Applied, thanks.

-- PMM